Finishing touches for `#[expect]` (RFC 2383) by xFrednet · Pull Request #98507 · rust-lang/rust

xFrednet · 2022-06-25T22:11:03Z

This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature.

As part of this PR, I've also updated clippy::duplicate_mod to showcase how this new functionality can be used and to ensure that it works correctly.

changelog: [duplicate_mod]: Fixed lint attribute interaction

r? @wesleywiser

cc: #97660, #85549

And I guess that's it. Here have a magical unicorn 🦄

rust-highfive · 2022-06-25T22:11:05Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

wesleywiser

r=me 🙂

…2383) Examples: NON_ASCII_IDENTS, UNCOMMON_CODEPOINTS, CONFUSABLE_IDENTS, MIXED_SCRIPT_CONFUSABLES

xFrednet · 2022-07-06T20:06:44Z

Sir Bors, I hereby formally declare this PR as r+ed by lord wesleywiser.

bors · 2022-07-06T20:06:46Z

📌 Commit a2810cd has been approved by wesleywiser

…n-magic, r=wesleywiser Finishing touches for `#[expect]` (RFC 2383) This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature. As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly. --- changelog: [`duplicate_mod`]: Fixed lint attribute interaction r? `@wesleywiser` cc: rust-lang#97660, rust-lang#85549 And I guess that's it. Here have a magical unicorn 🦄

…n-magic, r=wesleywiser Finishing touches for `#[expect]` (RFC 2383) This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature. As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly. --- changelog: [`duplicate_mod`]: Fixed lint attribute interaction r? ``@wesleywiser`` cc: rust-lang#97660, rust-lang#85549 And I guess that's it. Here have a magical unicorn 🦄

…n-magic, r=wesleywiser Finishing touches for `#[expect]` (RFC 2383) This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature. As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly. --- changelog: [`duplicate_mod`]: Fixed lint attribute interaction r? ```@wesleywiser``` cc: rust-lang#97660, rust-lang#85549 And I guess that's it. Here have a magical unicorn 🦄

Rollup of 8 pull requests Successful merges: - rust-lang#96856 (Fix ProjectionElem validation) - rust-lang#97711 (Improve soundness of rustc_arena) - rust-lang#98507 (Finishing touches for `#[expect]` (RFC 2383)) - rust-lang#98692 (rustdoc: Cleanup more FIXMEs) - rust-lang#98901 (incr: cache dwarf objects in work products) - rust-lang#98930 (Make MIR basic blocks field public) - rust-lang#98973 (Remove (unused) inherent impl anchors) - rust-lang#98981 ( Edit `rustc_mir_dataflow::framework` documentation ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…n-magic, r=wesleywiser Finishing touches for `#[expect]` (RFC 2383) This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature. As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly. --- changelog: [`duplicate_mod`]: Fixed lint attribute interaction r? `@wesleywiser` cc: rust-lang#97660, rust-lang#85549 And I guess that's it. Here have a magical unicorn 🦄

rust-highfive assigned wesleywiser Jun 25, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 25, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2022

xFrednet added the F-lint_reasons `#![feature(lint_reasons)]` label Jun 25, 2022

xFrednet force-pushed the rfc-2383-manual-expectation-magic branch from 5a131dc to d655b1dCompare June 25, 2022 22:14

xFrednet mentioned this pull request Jun 25, 2022
Tracking issue for RFC 2383, "Lint Reasons RFC" #54503
Closed
6 tasks

xFrednet force-pushed the rfc-2383-manual-expectation-magic branch from d655b1d to 2bb6f91Compare June 26, 2022 10:44

flip1995 reviewed Jun 27, 2022
View reviewed changes

Comment threadsrc/tools/clippy/tests/ui-cargo/duplicate_mod/fail/src/main.rs Outdated

wesleywiser approved these changes Jul 6, 2022
View reviewed changes

Comment threadcompiler/rustc_lint_defs/src/builtin.rs Outdated

xFrednet added 3 commits July 6, 2022 22:01

Document, that some lint have to be expected on the crate level (RFC …
6c6388c
…2383) Examples: NON_ASCII_IDENTS, UNCOMMON_CODEPOINTS, CONFUSABLE_IDENTS, MIXED_SCRIPT_CONFUSABLES

Add function to manually fulfill lint expectations (RFC 2383)
c8b4873

Fix #[expect] and #[allow] for clippy::duplicate_mod
a2810cd

xFrednet force-pushed the rfc-2383-manual-expectation-magic branch from 2bb6f91 to a2810cdCompare July 6, 2022 20:01

This comment was marked as off-topic.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2022

Dylan-DPC mentioned this pull request Jul 7, 2022
Rollup of 7 pull requests #99001
Closed

Dylan-DPC mentioned this pull request Jul 7, 2022
Rollup of 7 pull requests #99003
Closed

Dylan-DPC mentioned this pull request Jul 7, 2022
Rollup of 7 pull requests #99007
Closed

Dylan-DPC mentioned this pull request Jul 7, 2022
Rollup of 8 pull requests #99014
Merged

bors merged commit c815fef into rust-lang:masterJul 7, 2022

rustbot added this to the 1.64.0 milestone Jul 7, 2022

xFrednet deleted the rfc-2383-manual-expectation-magic branch July 7, 2022 20:10

Navigation Menu

Uh oh!

Uh oh!

Finishing touches for `#[expect]` (RFC 2383) - #98507

Finishing touches for `#[expect]` (RFC 2383)#98507
bors merged 3 commits into
rust-lang:masterfrom
xFrednet:rfc-2383-manual-expectation-magic

xFrednet commented Jun 25, 2022

Uh oh!

rust-highfive commented Jun 25, 2022

Uh oh!

Uh oh!

wesleywiser left a comment

Uh oh!

Uh oh!

This comment was marked as off-topic.

xFrednet commented Jul 6, 2022•
edited
Loading

Uh oh!

bors commented Jul 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

xFrednet commented Jun 25, 2022

Uh oh!

rust-highfive commented Jun 25, 2022

Uh oh!

Uh oh!

wesleywiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as off-topic.

xFrednet commented Jul 6, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xFrednet commented Jul 6, 2022•
edited
Loading