Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Cleanup more FIXMEs - #98692
Merged
Merged
Conversation
In this case, it seems fine to have the field be the inverse of the flag, especially the `enable` vs `disable` terminology is clear.
GuillaumeGomez
approved these changes
Jun 30, 2022
GuillaumeGomez
commented
Jun 30, 2022
Member
Thanks! @bors r+ rollup |
bors
commented
Jun 30, 2022
Collaborator
📌 Commit 2d2fd31 has been approved by |
camelid
commented
Jul 7, 2022
MemberAuthor
Hmm, bors seems to have forgotten. @bors r=GuillaumeGomez rollup |
bors
commented
Jul 7, 2022
Collaborator
📌 Commit 2d2fd31 has been approved by |
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 7, 2022
rustdoc: Cleanup more FIXMEs r? `@GuillaumeGomez`
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 7, 2022
rustdoc: Cleanup more FIXMEs r? ``@GuillaumeGomez``
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 7, 2022
rustdoc: Cleanup more FIXMEs r? ```@GuillaumeGomez```
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#96856 (Fix ProjectionElem validation) - rust-lang#97711 (Improve soundness of rustc_arena) - rust-lang#98507 (Finishing touches for `#[expect]` (RFC 2383)) - rust-lang#98692 (rustdoc: Cleanup more FIXMEs) - rust-lang#98901 (incr: cache dwarf objects in work products) - rust-lang#98930 (Make MIR basic blocks field public) - rust-lang#98973 (Remove (unused) inherent impl anchors) - rust-lang#98981 ( Edit `rustc_mir_dataflow::framework` documentation ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez