Uh oh!
There was an error while loading. Please reload this page.
interpret: refactor allocation info query - #98563
Merged
Merged
Conversation
We now have an infallible function that also tells us which kind of allocation we are talking about. Also we do longer have to distinguish between data and function allocations for liveness.
rust-highfive
commented
Jun 27, 2022
Contributor
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
oli-obk
commented
Jun 27, 2022
Contributor
@bors r+ |
bors
commented
Jun 27, 2022
Collaborator
📌 Commit b094116 has been approved by |
RalfJung
commented
Jun 27, 2022
MemberAuthor
@bors r=oli-obk |
bors
commented
Jun 27, 2022
Collaborator
📌 Commit 8e73c3e has been approved by |
RalfJungforce-pushed
the
interpret-alloc-check
branch
from
June 27, 2022 16:56
8e73c3e to
b094116CompareRalfJung
commented
Jun 27, 2022
MemberAuthor
@bors r=oli-obk |
bors
commented
Jun 27, 2022
Collaborator
📌 Commit 8e73c3e has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#98331 (Fix rustdoc argument error) - rust-lang#98506 (Fix span issues in object safety suggestions) - rust-lang#98563 (interpret: refactor allocation info query) - rust-lang#98576 (small regions refactoring) - rust-lang#98577 (Fix "kind" for associated types in trait implementations in rustdoc JSON) - rust-lang#98578 (Remove eddyb from miri failure pings) - rust-lang#98579 (liballoc tests: avoid int2ptr cast) - rust-lang#98581 (Add triagebot mentions.) - rust-lang#98587 (libcore tests: avoid int2ptr casts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have an infallible function that also tells us which kind of allocation we are talking about.
Also we do longer have to distinguish between data and function allocations for liveness.
This will help us to avoid "catching"
InterpErrors in Miri.r? @oli-obk