Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #98591
Conversation
We now have an infallible function that also tells us which kind of allocation we are talking about. Also we do longer have to distinguish between data and function allocations for liveness.
see comment added to the field in `VerifyBoundCx`.
…=notriddle Fix rustdoc argument error Fixesrust-lang#88756. It's a take over of rust-lang#88831. I cherry-picked the commits, fixed the merge conflict and the failing test. cc `@inashivb` `@jyn514` r? `@notriddle`
…stions, r=oli-obk Fix span issues in object safety suggestions Fixesrust-lang#98500
…li-obk interpret: refactor allocation info query We now have an infallible function that also tells us which kind of allocation we are talking about. Also we do longer have to distinguish between data and function allocations for liveness. This will help us to avoid "catching" `InterpError`s in Miri. r? `@oli-obk`
…kh726 small regions refactoring these commits should be fairly self-contained r? rust-lang/types
…notriddle Fix "kind" for associated types in trait implementations in rustdoc JSON Fixesrust-lang#81340. Contrary to what is suggested in the issue, I really think we should distinguish between associated items and "normal" constants and types. cc `@CraftSpider` `@SimonSapin` r? `@notriddle`
Remove eddyb from miri failure pings r? `@eddyb`
liballoc tests: avoid int2ptr cast I think we don't need `ptr::from_exposed_addr` here; `ptr::invalid` should be enough for this test. (And this makes Miri less unhappy when running these tests.)
…mulacrum Add triagebot mentions. This migrates the configuration of mentions from highfive to triagebot. I also fixed a few broken paths (error_codes.rs src/librustdoc/html/static/themes src/librustdoc/html/static/themes/ayu.css).
libcore tests: avoid int2ptr casts We don't need any of these pointers to actually be dereferenceable so using `ptr::invalid` should be fine. And then we can run Miri with strict provenance enforcement on the tests.
matthiaskrgr
commented
Jun 27, 2022
@bors r+ rollup=never p=9 |
bors
commented
Jun 27, 2022
📌 Commit f266821 has been approved by |
bors
commented
Jun 27, 2022
bors
commented
Jun 28, 2022
☀️ Test successful - checks-actions |
rust-highfive
commented
Jun 28, 2022
Tested on commit rust-lang/rust@7f08d04. Direct link to PR: <rust-lang/rust#98591> 💔 miri on windows: test-pass → build-fail (cc @RalfJung@oli-obk). 💔 miri on linux: test-pass → build-fail (cc @RalfJung@oli-obk).
rust-timer
commented
Jun 28, 2022
Finished benchmarking commit (7f08d04): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
rylev
commented
Jun 28, 2022
It seems like #98576 is probably the only likely candidate for this regression. @lcnr any thoughts on this? The cachegrind diff didn't reveal anything immediately interesting to me: |
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup