Enable raw-dylib for bin crates by dpaoliello · Pull Request #98989 · rust-lang/rust

dpaoliello · 2022-07-06T20:56:06Z

When raw-dylib is used in a bin crate, we need to collect all of the raw-dylib functions, generate the import library and add that to the linker command line.

I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.

rustbot · 2022-07-06T20:56:09Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

rust-highfive · 2022-07-06T20:56:09Z

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

compiler-errors · 2022-07-06T21:45:49Z

r? rust-lang/compiler

dpaoliello · 2022-07-07T17:48:11Z

r? @michaelwoerister

michaelwoerister

Thanks for the PR, @dpaoliello! This looks good to me.

I'm asking for some additional documentation below. Other than that, this looks good to go.

michaelwoerister · 2022-07-22T15:40:05Z

Thanks, @dpaoliello!
@bors r+

bors · 2022-07-22T15:40:07Z

📌 Commit 55118aa501bc31e74996aa7dbd62703202091a98 has been approved by michaelwoerister

It is now in the queue for this repository.

michaelwoerister · 2022-07-22T15:41:22Z

This PR modifies platform-specific run-make tests, which can be quite iffy in CI, so:
@bors rollup=never

bors · 2022-07-22T16:16:37Z

⌛ Testing commit 55118aa501bc31e74996aa7dbd62703202091a98 with merge ff37062700ca00a222586134fe66202229a67ea1...

bors · 2022-07-22T16:52:05Z

💔 Test failed - checks-actions

michaelwoerister · 2022-07-25T16:45:46Z

@bors r+

bors · 2022-07-25T16:45:48Z

📌 Commit 1f33785 has been approved by michaelwoerister

It is now in the queue for this repository.

bors · 2022-07-26T01:47:37Z

⌛ Testing commit 1f33785 with merge daaae25...

bors · 2022-07-26T04:28:35Z

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing daaae25 to master...

rust-timer · 2022-07-26T05:45:14Z

Finished benchmarking commit (daaae25): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.2%	0.2%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	3.2%	3.2%	1
Regressions 😿 (secondary)	9.7%	9.7%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	3.2%	3.2%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.6%	3.0%	5
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.1%	-2.1%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

…ister Enable raw-dylib for bin crates Fixesrust-lang#93842 When `raw-dylib` is used in a `bin` crate, we need to collect all of the `raw-dylib` functions, generate the import library and add that to the linker command line. I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.

rust-highfive assigned compiler-errors Jul 6, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 6, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2022

This comment has been minimized.
Sign in to view

dpaoliello force-pushed the rawdylibbin branch from 0a025b3 to 09b5ec4Compare July 6, 2022 21:20

This comment has been minimized.
Sign in to view

rust-highfive assigned nagisa and unassigned compiler-errors Jul 6, 2022

dpaoliello force-pushed the rawdylibbin branch from 09b5ec4 to 09f54e9Compare July 6, 2022 22:29

This comment has been minimized.
Sign in to view

dpaoliello force-pushed the rawdylibbin branch from 09f54e9 to f612581Compare July 6, 2022 22:36

This comment has been minimized.
Sign in to view

dpaoliello force-pushed the rawdylibbin branch from f612581 to f2f51a6Compare July 6, 2022 22:44

rust-highfive assigned michaelwoerister and unassigned nagisa Jul 7, 2022

michaelwoerister reviewed Jul 21, 2022
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated

dpaoliello force-pushed the rawdylibbin branch from f2f51a6 to 55118aaCompare July 21, 2022 18:04

dpaoliello requested a review from michaelwoerister July 21, 2022 18:29

michaelwoerister approved these changes Jul 22, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2022

Enable raw-dylib for binaries
1f33785

dpaoliello force-pushed the rawdylibbin branch from 55118aa to 1f33785Compare July 22, 2022 16:56

dpaoliello requested a review from michaelwoerister July 22, 2022 16:56

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 26, 2022

bors merged commit daaae25 into rust-lang:masterJul 26, 2022

rustbot added this to the 1.64.0 milestone Jul 26, 2022

This was referenced Jul 26, 2022
Rewrite LLVM's archive writer in Rust #97485
Merged
Add tests for raw-dylib with vectorcall, and fix vectorcall code generation #99476
Merged

dpaoliello mentioned this pull request Jul 26, 2022
Tracking issue for RFC 2627: #[link(kind="raw-dylib")] #58713
Open
17 tasks

dpaoliello deleted the rawdylibbin branch August 15, 2022 17:09

Uh oh!

Uh oh!

Conversation

dpaoliello commented Jul 6, 2022

Uh oh!

rustbot commented Jul 6, 2022

Uh oh!

rust-highfive commented Jul 6, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

compiler-errors commented Jul 6, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

dpaoliello commented Jul 7, 2022

Uh oh!

michaelwoerister left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michaelwoerister commented Jul 22, 2022

Uh oh!

bors commented Jul 22, 2022

Uh oh!

michaelwoerister commented Jul 22, 2022

Uh oh!

bors commented Jul 22, 2022

Uh oh!

bors commented Jul 22, 2022

Uh oh!

This comment has been minimized.

michaelwoerister commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

bors commented Jul 26, 2022

Uh oh!

bors commented Jul 26, 2022

Uh oh!

rust-timer commented Jul 26, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants