Skip to content

[WIP] add -Z split_bundled_libs - #99773

Closed
Bryanskiy wants to merge 14 commits into
rust-lang:masterfrom
Bryanskiy:bundle-whole-archive
Closed

[WIP] add -Z split_bundled_libs#99773
Bryanskiy wants to merge 14 commits into
rust-lang:masterfrom
Bryanskiy:bundle-whole-archive

Conversation

@Bryanskiy

@BryanskiyBryanskiy commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

related to #99429

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 26, 2022
@rust-highfive

rust-highfive commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@petrochenkov

petrochenkov commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

r? @petrochenkov

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Jul 27, 2022
View reviewed changes
Comment threadcompiler/rustc_session/src/options.rs
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadsrc/test/run-make/native-link-modifier-bundle-split/Makefile Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2022
@Bryanskiy

Bryanskiy commented Jul 28, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2022
petrochenkov
petrochenkov reviewed Jul 28, 2022
View reviewed changes
Comment threadsrc/test/run-make/native-link-modifier-bundle/Makefile Outdated
@petrochenkov

petrochenkov commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

We need feedback from Cargo team on this approach (keeping native libraries bundled into a rlib in separate files next to the rlib).
I made a Zulip thread about this a few days ago - https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Bundled.20static.20libraries.20as.20separate.20files.
We are ready to do the implementation work in cargo if necessary.

@petrochenkovpetrochenkov added S-waiting-on-team T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
@Bryanskiy
Bryanskiyforce-pushed the bundle-whole-archive branch from 256573d to 1215ea4CompareJuly 29, 2022 09:04
@bors

bors commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #99467) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkovpetrochenkov mentioned this pull request Aug 2, 2022
Closed
@petrochenkov

petrochenkov commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

Closing in favor of #100101.
We need to at least land and stabilize that PR before trying to make a next step like this.

@workingjubileeworkingjubilee added the A-CLI Area: Command-line interface (CLI) to the compiler label Mar 5, 2023
@Bryanskiy
Bryanskiy deleted the bundle-whole-archive branch May 18, 2023 12:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

A-CLIArea: Command-line interface (CLI) to the compilerT-cargoRelevant to the cargo team, which will review and decide on the PR/issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Bryanskiy@rust-highfive@petrochenkov@rust-log-analyzer@bors@estebank@workingjubilee@rustbot