Skip to content

change rlib format to distinguish native dependencies - #100101

Merged
bors merged 1 commit into
rust-lang:masterfrom
belovdv:issue-99429
Sep 13, 2022
Merged

change rlib format to distinguish native dependencies#100101
bors merged 1 commit into
rust-lang:masterfrom
belovdv:issue-99429

Conversation

@belovdv

@belovdvbelovdv commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Another one method to solve problem mentioned in #99429.

Changed .rlib format, it contains all bundled native libraries as archieves.
At link time rlib is unpacked and native dependencies linked separately.
New behavior hidden under separate_native_rlib_dependencies flag.

@rust-highfive

rust-highfive commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 3, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@petrochenkov

petrochenkov commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

r? @petrochenkov

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@belovdv

belovdv commented Aug 4, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2022
petrochenkov
petrochenkov reviewed Aug 4, 2022
View reviewed changes
Comment threadcompiler/rustc_session/src/options.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022
bjorn3
bjorn3 reviewed Aug 4, 2022
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
bjorn3
bjorn3 reviewed Aug 5, 2022
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
bjorn3
bjorn3 reviewed Aug 5, 2022
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
petrochenkov
petrochenkov reviewed Aug 5, 2022
View reviewed changes
Comment threadcompiler/rustc_session/src/options.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
bjorn3
bjorn3 reviewed Aug 6, 2022
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/back/archive.rs Outdated
@belovdv
belovdvforce-pushed the issue-99429 branch 2 times, most recently from 44e35fd to a60525eCompareAugust 7, 2022 12:05
@belovdv

belovdv commented Aug 24, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
@petrochenkov

petrochenkov commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 4f93a313f477731549ebfcabd2fc932ed15f229f has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@petrochenkovpetrochenkov mentioned this pull request Aug 26, 2022
Closed
@bors

This comment was marked as resolved.

Sign in to view
@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 27, 2022
@belovdv

belovdv commented Aug 28, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@petrochenkov

petrochenkov commented Aug 28, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5bf9c7b has been approved by petrochenkov

It is now in the queue for this repository.

@matthiaskrgrmatthiaskrgr mentioned this pull request Sep 2, 2022
Closed
@matthiaskrgr

matthiaskrgr commented Sep 2, 2022

Copy link
Copy Markdown
Member

@bors r- rollup=never
failed in a rollup #101326

@bors

This comment was marked as resolved.

Sign in to view
@rustbot

rustbot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@belovdv

belovdv commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@petrochenkov

petrochenkov commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit ffa8359 has been approved by petrochenkov

It is now in the queue for this repository.

@bors

bors commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors

bors commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ffa8359 with merge 9da4644...

@bors

bors commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 9da4644 to master...

This was referenced Sep 13, 2022
Merged
Merged
@rust-timer

rust-timer commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9da4644): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-2.5%[-2.5%, -2.5%]1
Improvements ✅
(secondary)		-2.5%[-3.5%, -1.4%]2
All ❌✅ (primary)-2.5%[-2.5%, -2.5%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)		-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@ehussehuss mentioned this pull request Oct 14, 2022
Closed
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 30, 2023
Open
@amysparkamyspark mentioned this pull request Sep 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
@bjorn3bjorn3bjorn3 left review comments

Assignees

@petrochenkovpetrochenkov

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

11 participants

@belovdv@rust-highfive@rust-log-analyzer@rustbot@petrochenkov@bors@matthiaskrgr@TaKO8Ki@rust-timer@bjorn3@davidtwco