Skip to content

Use String::from_utf8_lossy in CStr demo - #99781

Merged
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:demo-string-from-cstr
Jul 29, 2022
Merged

Use String::from_utf8_lossy in CStr demo#99781
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:demo-string-from-cstr

Conversation

@workingjubilee

@workingjubileeworkingjubilee commented Jul 26, 2022

Copy link
Copy Markdown
Member

Fixes#99755.

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 26, 2022
@rustbot

rustbot commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
thomcc
thomcc reviewed Jul 26, 2022
View reviewed changes
Comment threadlibrary/core/src/ffi/c_str.rs Outdated
@thomcc

thomcc commented Jul 28, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 28, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d48a869 has been approved by thomcc

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
@JohnTitorJohnTitor mentioned this pull request Jul 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2022
@bors
Auto merge ofrust-lang#99892- JohnTitor:rollup-qi4fem8, r=JohnTitor
2f847b8
Rollup of 8 pull requests
Successful merges:
- rust-lang#99686 (add suggestion when there is a impl of external trait on pointer with wrong coherence rules)
- rust-lang#99760 (doc/rustc: describe the uefi target platforms)
- rust-lang#99766 (Htmldocck: Substitute the doc channel when blessing)
- rust-lang#99781 (Use String::from_utf8_lossy in CStr demo)
- rust-lang#99803 (Update mentions to `rustc_metadata::rmeta::Lazy`)
- rust-lang#99845 (Remove `$` prefix for bash scripts in doc)
- rust-lang#99850 (rustdoc: Remove more Clean trait implementations)
- rust-lang#99872 (Clone the `src/llvm-project` submodule if profiling is enabled)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9b3f49f into rust-lang:masterJul 29, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jul 29, 2022
@workingjubilee
workingjubilee deleted the demo-string-from-cstr branch June 6, 2025 05:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomccthomccthomcc left review comments

Assignees

@thomccthomcc

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

CStr::to_string_lossy

5 participants

@workingjubilee@rustbot@rust-highfive@thomcc@bors