Uh oh!
There was an error while loading. Please reload this page.
Remove $ prefix for bash scripts in doc - #99845
Merged
Merged
Conversation
rust-highfive
commented
Jul 28, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
GuillaumeGomez
approved these changes
Jul 28, 2022
GuillaumeGomez
commented
Jul 28, 2022
Member
@bors r+ rollup |
bors
commented
Jul 28, 2022
Collaborator
ContributorAuthor
I noticed that lots of bash scripts has the However, at instrument-coverage.md#L49, the script does not have the prefix. Which is right? Should I add all of them or remove all of them? |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99686 (add suggestion when there is a impl of external trait on pointer with wrong coherence rules) - rust-lang#99760 (doc/rustc: describe the uefi target platforms) - rust-lang#99766 (Htmldocck: Substitute the doc channel when blessing) - rust-lang#99781 (Use String::from_utf8_lossy in CStr demo) - rust-lang#99803 (Update mentions to `rustc_metadata::rmeta::Lazy`) - rust-lang#99845 (Remove `$` prefix for bash scripts in doc) - rust-lang#99850 (rustdoc: Remove more Clean trait implementations) - rust-lang#99872 (Clone the `src/llvm-project` submodule if profiling is enabled) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
xtexx
commented
Jul 29, 2022
ContributorAuthor
@GuillaumeGomez request for review, see the last comment for more. |
GuillaumeGomez
commented
Jul 29, 2022
Member
It's a visual marker to see the different commands. Whether or not it's there doesn't matter much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.