Uh oh!
There was an error while loading. Please reload this page.
Remove references to chalkify tests - #604
Merged
Merged
Conversation
Merged
LeSeulArtichaut
left a comment
Contributor
There was a problem hiding this comment.
If I understood well, the goal is to remove unit tests temporarily so Chalk can be upgraded. Unit tests will come back later, so this chapter is not deprecated at all.
Uh oh!
There was an error while loading. Please reload this page.
LeSeulArtichaut
suggested changes
Mar 7, 2020
Uh oh!
There was an error while loading. Please reload this page.
LeSeulArtichaut
previously approved these changes
Mar 7, 2020
LeSeulArtichaut
left a comment
Contributor
There was a problem hiding this comment.
Alright, three more nitpicks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JohnTitor
commented
Mar 7, 2020
MemberAuthor
Thanks! Addressed all things. |
LeSeulArtichaut
approved these changes
Mar 7, 2020
LeSeulArtichaut
left a comment
Contributor
There was a problem hiding this comment.
This time's the right one
JohnTitor
commented
Mar 7, 2020
MemberAuthor
Thanks for the review <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chalkify tests were removed entirely in rust-lang/rust#69247 but the lower-module chapter is still reasonable to me. So just removed the references to chalkify ui tests.