Uh oh!
There was an error while loading. Please reload this page.
refactor: restrict run_future() usages to tests - #3856
Merged
Conversation
djc
approved these changes
Jun 3, 2024
Uh oh!
There was an error while loading. Please reload this page.
rami3l
added this pull request to the merge queue
Jun 3, 2024
rami3l
removed this pull request from the merge queue due to a manual request
Jun 3, 2024
Uh oh!
There was an error while loading. Please reload this page.
djc
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3367, supersedes #3847.
This PR simply makes more function async, and thus the necessity of
run_future()in non-test code is completely eliminated.The only usages remaining are in
manifestation's tests, which is seemingly a bit harder than others considering lifetime restrictions and such.