Skip to content

test(manifestation): replace run_future() with TestContext - #3915

Merged
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:refactor/goodbye-run-future
Jun 27, 2024
Merged

test(manifestation): replace run_future() with TestContext#3915
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:refactor/goodbye-run-future

Conversation

@rami3l

@rami3lrami3l commented Jun 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

As a continuation of #3367 and #3856, this PR makes all tests in dist::manifestation::tests that rely on run_future() async, thus the latter can be fully removed.

@rami3l
rami3lforce-pushed the refactor/goodbye-run-future branch 6 times, most recently from 8ff50ee to cf17301CompareJune 27, 2024 06:25
@rami3l
rami3l marked this pull request as ready for review June 27, 2024 06:27
@rami3l
rami3l requested a review from djcJune 27, 2024 06:28
@rami3lrami3l added this to the 1.28.0 milestone Jun 27, 2024
djc
djc reviewed Jun 27, 2024
View reviewed changes

@djcdjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Would like some tweaks before I review this in a bit more detail...

Comment threadsrc/dist/manifestation/tests.rs
Comment threadsrc/dist/manifestation/tests.rs Outdated
@rami3l
rami3lforce-pushed the refactor/goodbye-run-future branch from cf17301 to 749f0c8CompareJune 27, 2024 09:55
@rami3l
rami3l requested a review from djcJune 27, 2024 09:56
@rami3lrami3l changed the title test(manifest): replace run_future() with TestContexttest(manifestation): replace run_future() with TestContextJun 27, 2024
@rami3l

rami3l commented Jun 27, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@djc I don't know how you'd like to proceed with your reviews, but just FYI I find this PR a perfect fit for language-aware diffs like SemanticDiff: https://app.semanticdiff.com/gh/rust-lang/rustup/pull/3915/commits

djc
djc approved these changes Jun 27, 2024
View reviewed changes
Comment threadsrc/dist/manifestation/tests.rs
Comment threadsrc/dist/manifestation/tests.rs
@djc

djc commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

@djc I don't know how you'd like to proceed with your reviews, but just FYI I find this PR a perfect fit for language-aware diffs like SemanticDiff: https://app.semanticdiff.com/gh/rust-lang/rustup/pull/3915/commits

Ooohhh, that is pretty awesome. Should try to use that more.

@rami3l
rami3l added this pull request to the merge queue Jun 27, 2024
Merged via the queue into rust-lang:master with commit ad668d9Jun 27, 2024
@rami3l
rami3l deleted the refactor/goodbye-run-future branch June 27, 2024 11:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djcdjcdjc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rami3l@djc