Uh oh!
There was an error while loading. Please reload this page.
Support panics across stack growth boundaries - #7
Conversation
alexcrichton
commented
Nov 16, 2018
Ok looks like the segfault here is showing up on MSVC |
alexcrichton
commented
Nov 16, 2018
FWIW it's likely the case that https://github.com/alexcrichton/stacker/pull/4 needs to be dusted off to solve the MSVC issues |
oli-obk
commented
Nov 22, 2018
Would you be ok with disabling windows support for now and using the fallback? |
alexcrichton
commented
Nov 22, 2018
It's fine to not support windows in this crate, but it's not fine to do that in the compiler unfortunately |
oli-obk
commented
Nov 22, 2018
The compiler currently does not use this at all, using stacker while only supporting linux/mac would fix the regression issues we have open. There are none on windows as of now. |
alexcrichton
commented
Nov 22, 2018
The stack size isn't really magically larger on Windows though, so the lack of reports on Windows doesn't mean it doesn't exist there, just that it hasn't been run into yet. It's the same bug on all platforms, and we can't fix it on 2/3 tier 1 platforms. |
oli-obk
commented
Nov 26, 2018
True, but I don't see #8 getting ready for being merged before the beta freeze. Isn't it better to fix a bug on 2/3 of the platforms with a plan for fixing the last 1/3rd later, than to let the regression run into beta and stable? |
alexcrichton
commented
Nov 27, 2018
I personally feel (others may wish to weigh in) that we can't fix 2/3 tier 1 platforms. This fix must be uniform across all tier 1 platforms. |
alexcrichton
commented
Dec 10, 2018
I think this is supported and tested with https://github.com/alexcrichton/stacker/pull/8, so closing! |
No description provided.