Use fibers on windows by oli-obk · Pull Request #8 · rust-lang/stacker

oli-obk · 2018-11-23T14:52:03Z

No description provided.

…ble unwinding, catching panics and backtraces.

alexcrichton

Thanks! My main hesitation here continues to be that there's no comments anywhere and I have no idea how any of this works, so some comments would be greatly welcome!

alexcrichton · 2018-11-23T16:44:39Z

+ }
+ } else {
+ #[inline(always)]
+ fn get_thread_stack_guarantee() -> usize {


Is this used because aren't all windows platforms x86/x86_64 righ tnow basically?

I did see someone trying to use Rust on ARM64

oli-obk · 2018-11-23T16:54:49Z

My main hesitation here continues to be that there's no comments anywhere and I have no idea how any of this works, so some comments would be greatly welcome!

That's why I didn't want to touch that PR :/

cc @Zoxc can you do a first round of documentation, maybe even with some links into windows-documentation? If it's completely out of your cache I can start reading up on the docs myself though.

oli-obk · 2018-11-28T09:08:55Z

@alexcrichton we lost appveyor on this repo it seems?

oli-obk · 2018-11-29T13:37:34Z

@Zoxc can you review the comments I added in the code?

oli-obk · 2018-11-29T13:38:43Z

+ cfg_if! {
+ if #[cfg(any(target_arch = "x86_64", target_arch = "x86"))] {
+ #[inline(always)]
+ // We cannot know the initial stack size on x86


@Zoxc this seems suspicious.

oli-obk · 2018-11-30T08:48:00Z

@alexcrichton deadlines are coming up fast. Do you think we could merge this and address additional documentation later?

alexcrichton · 2018-11-30T16:08:35Z

I think this is way too high risk to land in the edition release, and I would still personally prefer that someone takes the time to understand and document this.

oli-obk · 2018-12-06T12:06:59Z

mingw failures are probably related to rust-lang/rust#53454

alexcrichton · 2018-12-07T21:33:45Z

Ok great! I'll take a closer look at this on Monday where I should have access to a windows computer and can dig in a bit more

mati865 · 2018-12-09T08:16:52Z

Appveryor is configured to use headers from MSYS2 and libs copied from mingw-builds GCC 7.2 package. This ABI mismatch is only getting worse as the time goes by.
Oldest issue about this is rust-lang/rust#47048

Another error (this time caused by this PR) is multiple definition of __stacker_black_box() which is defined in both .S and .c files.

mati865 · 2018-12-10T12:59:18Z

@@ -1,4 +1,4 @@
-#if defined(APPLE) || (defined(WINDOWS) && defined(X86))


32 bit Windows does use additional leading _, you'll have to revert this change.

Zoxc · 2018-12-10T21:04:27Z

- fn __stacker_black_box(t: *const u8);
-}
+#[inline(never)]
+fn __stacker_black_box(_: *const u8) {}


This is a not a black box. LLVM can see what is inside ;)

alexcrichton · 2018-12-10T21:22:46Z

Alright I've done a once-over of all this and it all looks good to me. Local testing looks good too although I'm not configured locally to do all the MinGW targets. That's what we have bors for though!

Thanks again for pushing this through @oli-obk and @Zoxc!

Zoxc · 2018-12-10T23:00:34Z

This did fail on my Fedora VM last time I tried. That means that there's probably something wrong in the unix code :/

alexcrichton · 2018-12-10T23:22:27Z

Ah ok, if you can get a reproduction we can dig in!

Zoxcand others added 3 commits November 23, 2018 15:50

Use fibers on Windows. Use CFI instructions on other platforms to ena…
63c7745
…ble unwinding, catching panics and backtraces.

Use mmap and create a guard page
37f1f8a

Add some integration tests
1dd4281

This was referenced Nov 23, 2018
Add some integration tests #6
Closed
Use fibers on Windows. Use CFI instructions on other platforms to enable unwinding, catching panics and backtraces. #4
Closed

alexcrichton reviewed Nov 23, 2018
View reviewed changes

Zoxc reviewed Nov 24, 2018
View reviewed changes

Comment threadsrc/lib.rs Outdated

This was referenced Nov 26, 2018
Support panics across stack growth boundaries #7
Closed
Prevent compiler stack overflow for deeply recursive code rust-lang/rust#55617
Merged

oli-obk added 2 commits November 28, 2018 08:28

Reintroduce __stacker_stack_pointer
687c5fc

Explain magic numbers
141d742

Zoxc reviewed Nov 28, 2018
View reviewed changes

Comment threadsrc/arch/x86_64.asm

Zoxc reviewed Nov 28, 2018
View reviewed changes

Comment threadsrc/arch/i686.asm

Zoxc reviewed Nov 28, 2018
View reviewed changes

Comment threadbuild.rs

Zoxc reviewed Nov 28, 2018
View reviewed changes

Comment threadsrc/lib.rs Outdated

oli-obk added 6 commits November 28, 2018 10:18

Reintroduce windows asm for __stacker_stack_pointer
7778a6c

Implement windows without C
e96b9ef

Remove unnecessary parentheses
4ebbeca

Overallocate on platforms without stack size probing support
da91897

Document a few more function calls
76eb767

Document some more things
0d67572

oli-obk commented Nov 29, 2018
View reviewed changes

oli-obk mentioned this pull request Dec 3, 2018
regression: stack overflow on macosx with xcode 6.4 rust-lang/rust#55471
Closed

Zoxcand others added 2 commits December 3, 2018 12:07

Fix things
a8875a4

Fill out partial comment
1f0706c

Implement black box inside test file
0a03ce9

mati865 reviewed Dec 10, 2018
View reviewed changes

32 bit windows uses _ prefixes for globals
1d37dc0

Zoxc reviewed Dec 10, 2018
View reviewed changes

alexcrichton added 2 commits December 10, 2018 13:08

Switch to winapi 0.3
70cbe92

Touch up style a bit in fibers implementation
2c3befa

alexcrichton merged commit 6e5d422 into rust-lang:masterDec 10, 2018

alexcrichton mentioned this pull request Dec 10, 2018
Not safe to use #1
Closed

		@@ -1,4 +1,4 @@
		#if defined(APPLE) \|\| (defined(WINDOWS) && defined(X86))

Uh oh!

Conversation

oli-obk commented Nov 23, 2018

Uh oh!

alexcrichton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexcrichtonNov 23, 2018

Choose a reason for hiding this comment

Uh oh!

ZoxcNov 28, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Nov 23, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Nov 28, 2018

Uh oh!

oli-obk commented Nov 29, 2018

Uh oh!

oli-obkNov 29, 2018

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Nov 30, 2018

Uh oh!

alexcrichton commented Nov 30, 2018

Uh oh!

oli-obk commented Dec 6, 2018

Uh oh!

alexcrichton commented Dec 7, 2018

Uh oh!

mati865 commented Dec 9, 2018

Uh oh!

mati865Dec 10, 2018

Choose a reason for hiding this comment

Uh oh!

ZoxcDec 10, 2018

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Dec 10, 2018

Uh oh!

Zoxc commented Dec 10, 2018

Uh oh!

alexcrichton commented Dec 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants