Uh oh!
There was an error while loading. Please reload this page.
Turn std_detect into a no_std crate - #1005
Merged
Merged
Conversation
rust-highfive
commented
Feb 14, 2021
@Amanieu: no appropriate reviewer found, use r? to override |
Amanieuforce-pushed
the
detect_cleanup
branch
8 times, most recently
from
February 14, 2021 06:23
935acb8 to
fbf6e04CompareAmanieu
commented
Feb 14, 2021
MemberAuthor
It's not finished yet, I still need to remove dependencies on |
lu-zero
commented
Feb 14, 2021
Contributor
Poke me and I'll look into it again when ready :) |
Amanieu
marked this pull request as ready for review
February 14, 2021 12:07
Amanieuforce-pushed
the
detect_cleanup
branch
5 times, most recently
from
February 14, 2021 12:58
33ebdd1 to
eb0d413CompareAmanieu
commented
Feb 14, 2021
MemberAuthor
@lu-zero Should be ready for review now. |
lu-zero
reviewed
Feb 14, 2021
| } | ||
| } | ||
| cfg_if::cfg_if! { |
MemberAuthor
There was a problem hiding this comment.
It's never used.It's never tested.In fact the feature flag is even missing fromCargo.toml.
So apparently I'm bad at grep and completely missed the test cases in the CI config in .github. I'll undo the removal.
MemberAuthor
There was a problem hiding this comment.
I changed std_detect_env_override to use libc instead of std.
Member
There was a problem hiding this comment.
Does this work on Windows? I did guess not.
lu-zero
approved these changes
Feb 14, 2021
lu-zero
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me, thank you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to turn
std_detectinto a properno_stdcrate so that we can avoid dealing with the mess of including it as a submodule ofstd.