Uh oh!
There was an error while loading. Please reload this page.
make is_{arch}_feature_detected! available for std - #1081
Conversation
rust-highfive
commented
Mar 13, 2021
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Amanieu
commented
Mar 13, 2021
Note that with #1005, |
the8472
commented
Mar 13, 2021
Will std be updated to use it that way in the near future? |
Amanieu
commented
Mar 13, 2021
Yes, I plan on updating the stdarch submodule in std as soon as #1052 lands, which is blocked on rust-lang/rust#82838. |
Amanieu
commented
Mar 13, 2021
Actually there might be a libs team FCP on the merge due to the const generics changes, which may take a while to resolve. |
the8472
commented
Mar 13, 2021
Well, this only for a small optimization. I'll just submit a rust PR and note that it's blocked. |
The feature detection macros currently can't be used in std itself due to these errors.
The workaround in this PR was suggested in this zulip discussion