Uh oh!
There was an error while loading. Please reload this page.
CI: Run Clippy for (nearly) all targets. - #447
Conversation
2bfdbca to
f40ba84CompareEnsure that Clippy is looking at as much of the target-specific code as practical.
| pub fn getrandom_inner(dest: &mut [MaybeUninit<u8>]) -> Result<(), Error> { | ||
| // Prevent overflow of u32 | ||
| for chunk in dest.chunks_mut(u32::max_value() as usize) { | ||
| for chunk in dest.chunks_mut(u32::MAX as usize) { |
There was a problem hiding this comment.
With the changes to tests.yml, clippy now sees this code.
briansmith
commented
Jun 1, 2024
The CI failure is the typical Windows wasm32 error. |
| - if: ${{ matrix.toolchain == 'nightly' }} | ||
| run: cargo test --benches | ||
| - if: ${{ matrix.toolchain == 'stable' }} | ||
| run: cargo clippy --all |
There was a problem hiding this comment.
Running Clippy on stable would mean that we can get failing CI on new stable releases. Usually I prefer to fix Clippy version and bump it manually form time to time.
Maybe we should add a single Clippy job which will check a set of targets using cargo clippy --target?
There was a problem hiding this comment.
+1 to using some fixed nightly Clippy and running it on a bunch of targets in a single job
There was a problem hiding this comment.
If we want to run clippy on targets which don't have libstd pre built, we will have to use -Z build_std
newpavlov
commented
Jun 14, 2024
Closing in favor of #477. |
Ensure that Clippy is looking at as much of the target-specific code as practical.