Uh oh!
There was an error while loading. Please reload this page.
Replace more casts with safer conversions & enable cast-related lints. - #445
Closed
briansmith wants to merge 7 commits into
Closed
Replace more casts with safer conversions & enable cast-related lints.#445briansmith wants to merge 7 commits into
briansmith wants to merge 7 commits into
Conversation
briansmithforce-pushed
the
b/casts-3-2
branch
3 times, most recently
from
May 31, 2024 23:40
d29aa27 to
125a3e6Comparebriansmith
commented
Jun 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
briansmith
marked this pull request as ready for review
June 1, 2024 00:12
briansmithforce-pushed
the
b/casts-3-2
branch
2 times, most recently
from
June 1, 2024 18:59
d9b4a3a to
90b24d4Comparebriansmith
commented
Jun 1, 2024
ContributorAuthor
I have rebased this on top of #447 and extended it to address additional Clippy feedback from that change. |
briansmithforce-pushed
the
b/casts-3-2
branch
13 times, most recently
from
June 2, 2024 20:25
f331ab0 to
67f3bd5Comparebriansmith
commented
Jun 2, 2024
ContributorAuthor
briansmithforce-pushed
the
b/casts-3-2
branch
2 times, most recently
from
June 2, 2024 20:47
4008b07 to
7a89e48Comparebriansmith
marked this pull request as draft
June 6, 2024 19:29
briansmith
commented
Jun 6, 2024
ContributorAuthor
usize and u32 both implement `From<u16>` so use u16 for the length.
Comment on lines
+211
to
+225
| #![deny( | ||
| clippy::cast_lossless, | ||
| clippy::cast_possible_truncation, | ||
| clippy::cast_possible_wrap, | ||
| clippy::cast_precision_loss, | ||
| clippy::cast_ptr_alignment, | ||
| clippy::cast_sign_loss, | ||
| clippy::char_lit_as_u8, | ||
| clippy::checked_conversions, | ||
| clippy::fn_to_numeric_cast, | ||
| clippy::fn_to_numeric_cast_with_truncation, | ||
| clippy::ptr_as_ptr, | ||
| clippy::unnecessary_cast, | ||
| clippy::useless_conversion | ||
| )] |
Member
There was a problem hiding this comment.
Would it be possible to deny entire categories of lints (pedantic, correctness, complexity, etc...) rather than specific ones?
Member
There was a problem hiding this comment.
Also, with the number of additional lints it may be better to enable them in clippy.toml.
briansmithforce-pushed
the
b/casts-3-2
branch
2 times, most recently
from
June 21, 2024 03:38
d06067f to
4f8d78dCompare| for chunk in dest.chunks_mut(chunk_size) { | ||
| let ret = unsafe { RtlGenRandom(chunk.as_mut_ptr().cast::<c_void>(), chunk.len() as u32) }; | ||
| #[allow(clippy::cast_possible_truncation)] | ||
| let chunk_len = chunk.len() as u32; |
Member
There was a problem hiding this comment.
You can write it as chunk.len().try_into().expect("chunk size is bounded by i32::MAX"). Compiler is able to properly remove such panic.
| for chunk in dest.chunks_mut(WEB_CRYPTO_BUFFER_SIZE.into()) { | ||
| // The chunk can be smaller than buf's length, so we call to | ||
| // JS to create a smaller view of buf without allocation. | ||
| #[allow(clippy::cast_possible_truncation)] |
Member
There was a problem hiding this comment.
You can use .try_into().expect("..") here same as in windows7.
newpavlov
commented
Oct 9, 2024
Member
Closing in favor of #510. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.