Uh oh!
There was an error while loading. Please reload this page.
MSRV 1.59: Remove libc requirement for x86_64-*-linux-none - #461
Closed
briansmith wants to merge 3 commits into
Closed
MSRV 1.59: Remove libc requirement for x86_64-*-linux-none#461briansmith wants to merge 3 commits into
briansmith wants to merge 3 commits into
Conversation
briansmith
commented
Jun 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
briansmithforce-pushed
the
b/syscall-x86_64
branch
5 times, most recently
from
June 6, 2024 20:24
6533252 to
c60c94eComparePrepare for removing the libc dependency from it.
Make progress on reoving the libc dependency from util_unix, so we can remove the libc dependency for x86_64-unknown-linux-none.
briansmith
commented
Jun 7, 2024
| } | ||
| match Word::try_from(ret) { | ||
| Ok(written) => { | ||
| const _:() = assert!(core::mem::size_of::<Word>() <= core::mem::size_of::<usize>()); |
ContributorAuthor
There was a problem hiding this comment.
Depending on whether/how #463 is resolved, we may need to unpoison(dest, written) here.
| 0, | ||
| ) | ||
| }; | ||
| const _:() = assert!(core::mem::size_of::<libc::c_long>() == core::mem::size_of::<isize>()); |
briansmith
marked this pull request as ready for review
June 7, 2024 15:37
briansmith
commented
Jun 7, 2024
ContributorAuthor
Since the current implementation already doesn't work in MSAN (on Linux), we don't have to block this on MSAN support. |
briansmithforce-pushed
the
b/syscall-x86_64
branch
2 times, most recently
from
June 7, 2024 16:24
3ad27bf to
37386afComparebriansmith
commented
Jun 7, 2024
| // | ||
| // #[cfg(target_abi = "x832")] | ||
| // #[allow(non_upper_case_globals)] | ||
| // pub const SYS_getrandom: IWord = 318 | __X32_SYSCALL_BIT; |
ContributorAuthor
There was a problem hiding this comment.
It isn't clear to me that we actually need to use __X32_SYSCALL_BIT for x86_64-unknown-linux-gnux32 and other x32 targets. It seems like we could just use the 64-bit version of the syscall instead (i.e. same syscall number). But I am not so sure and it's hard for me to test x32.
…-none. Remove the last libc dependency from `linux_android`, as a step towards supporting x86_64-unknown-linux-none. This requires bumping the MSRV to 1.59.
newpavlov
commented
Oct 16, 2024
Member
Closing in favor of #520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.