Skip to content

feat: allow multithreaded fmindex construction - #208

Merged
sarahet merged 3 commits into
seqan:lambda3from
SGSSGene:feat/threaded_fmindex_construction
May 9, 2023
Merged

feat: allow multithreaded fmindex construction#208
sarahet merged 3 commits into
seqan:lambda3from
SGSSGene:feat/threaded_fmindex_construction

Conversation

@SGSSGene

Copy link
Copy Markdown
Collaborator
  • updates to newest fmindex
  • uses fmindex_collection now uses libsais instead of libdivsufsort
  • support for openmp
  • adds option to control the thread count for suffix array construction

@h-2h-2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR!

I think you still need to add libsais to the your library's cmake (or ours).

Comment threadsrc/mkindex_algo.hpp Outdated
@h-2

h-2 commented Apr 25, 2023

Copy link
Copy Markdown
Member

Do you know if memory usage changes between libdivsufsort and libsais? Currently, the memory requirements of lambda3's index construction are almost twice as high as lambda2's 😑

@SGSSGene
SGSSGeneforce-pushed the feat/threaded_fmindex_construction branch from cfaf5e3 to eddb7c3CompareApril 26, 2023 14:59
@SGSSGene

Copy link
Copy Markdown
CollaboratorAuthor

Do you know if memory usage changes between libdivsufsort and libsais? Currently, the memory requirements of lambda3's index construction are almost twice as high as lambda2's expressionless

No, I don't have any clue. I also don't know what influence the thread number will have on the memory consumption.

@SGSSGene
SGSSGeneforce-pushed the feat/threaded_fmindex_construction branch 5 times, most recently from 31fbc60 to 35c9bf9CompareApril 27, 2023 14:31
@SGSSGene
SGSSGene marked this pull request as ready for review April 27, 2023 14:51
@SGSSGene
SGSSGene requested a review from h-2April 27, 2023 17:53
SGSSGeneand others added 3 commits May 3, 2023 16:41
- This also changes the way that a search with an reversed index is
working, so no reversing of the text is required anymore.
- Requires to set the numbers of thread used for suffix array
construction.
Co-authored-by: Hannes Hauswedell <h2+github.com@fsfe.org>
@SGSSGene
SGSSGeneforce-pushed the feat/threaded_fmindex_construction branch from ffccda7 to 7b08976CompareMay 3, 2023 14:41
@sarahet
sarahet merged commit 7b08976 into seqan:lambda3May 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SGSSGene@h-2@sarahet