Uh oh!
There was an error while loading. Please reload this page.
impl std::io::Write for SmallVec - #52
Merged
Merged
Conversation
ContributorAuthor
this collides with the no_std pr because all other std modules are part of core but io is not. |
mbrubeck
commented
Jun 20, 2017
Collaborator
#49 has landed now, so this should be rebased on top of it, and |
chpio
commented
Jun 22, 2017
| drop(small_vec); | ||
| } | ||
| #[cfg(feature = "std")] |
ContributorAuthor
There was a problem hiding this comment.
Is that the correct way of doing this? I guess it is if you want the tests to pass on core.
mbrubeck
commented
Jun 22, 2017
Collaborator
@bors-servo r+ Yes, thanks! When merged with #53, this builds and passes tests both with and without the |
bors-servo
commented
Jun 22, 2017
Contributor
📌 Commit e96793e has been approved by |
bors-servo
commented
Jun 22, 2017
Contributor
bors-servo pushed a commit
that referenced
this pull request
Jun 22, 2017
impl std::io::Write for SmallVec <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/52) <!-- Reviewable:end -->
bors-servo
commented
Jun 22, 2017
Contributor
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is