Uh oh!
There was an error while loading. Please reload this page.
Add ExtendFromSlice trait - #54
Merged
Merged
Conversation
jdm
commented
Jun 27, 2017
Member
Could you split this into two separate commits? One for formatting changes, and the other for the actual implementation changes. |
eira-fransham
commented
Jun 28, 2017
ContributorAuthor
@jdm Sorry, I didn't intend to commit the formatting. I run |
mbrubeck
commented
Jun 28, 2017
Collaborator
@bors-servo r+ |
bors-servo
commented
Jun 28, 2017
Contributor
📌 Commit 226730c has been approved by |
bors-servo
commented
Jun 28, 2017
Contributor
bors-servo pushed a commit
that referenced
this pull request
Jun 28, 2017
Add ExtendFromSlice trait At Parity we tried to switch from our internal `elastic-array` crate (which has soundness and ergonomics issues) to `smallvec` but the PR that attempted this replaced `extend_from_slice` calls with `push` loops (which are much slower). We could fix this internally, but the discussion around it made me wonder if this would be something that could be useful upstream. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/54) <!-- Reviewable:end -->
bors-servo
commented
Jun 28, 2017
Contributor
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Parity we tried to switch from our internal
elastic-arraycrate (which has soundness and ergonomics issues) tosmallvecbut the PR that attempted this replacedextend_from_slicecalls withpushloops (which are much slower). We could fix this internally, but the discussion around it made me wonder if this would be something that could be useful upstream.This change is