Skip to content

Pin to Dask 2021.02.0 while incompatibility with later versions is investigated - #483

Merged
mergify[bot] merged 1 commit into
sgkit-dev:masterfrom
tomwhite:dask_2021.02.0
Mar 8, 2021
Merged

Pin to Dask 2021.02.0 while incompatibility with later versions is investigated#483
mergify[bot] merged 1 commit into
sgkit-dev:masterfrom
tomwhite:dask_2021.02.0

Conversation

@tomwhite

@tomwhitetomwhite commented Mar 8, 2021

Copy link
Copy Markdown
Member

No description provided.

@tomwhite

Copy link
Copy Markdown
MemberAuthor

This will fix the main build and the documentation build (see #482).

@jeromekelleherjeromekelleher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want to pin in setup.cfg? This does more than just fix the CI builds, doesn't it?

@tomwhite

Copy link
Copy Markdown
MemberAuthor

Are we sure we want to pin in setup.cfg? This does more than just fix the CI builds, doesn't it?

You're right. I was hoping this pin would be short-lived, and certainly wouldn't get released.

I can just change the requirements file though for CI.

@jeromekelleher

Copy link
Copy Markdown
Member

You're right. I was hoping this pin would be short-lived, and certainly wouldn't get released.

Pins have a habit of persisting, I'd rather keep it to a minimum, but it's up to you really.

@tomwhitetomwhite added the auto-merge Auto merge label for mergify test flight label Mar 8, 2021
@mergify
mergifyBot merged commit 12223d2 into sgkit-dev:masterMar 8, 2021
@jrbourbeau

Copy link
Copy Markdown

I'd be curious to know what changes in the Dask 2021.03.0 release impacted sgkit (apologies for any unexpected breakages)

@tomwhite

Copy link
Copy Markdown
MemberAuthor

I'd be curious to know what changes in the Dask 2021.03.0 release impacted sgkit (apologies for any unexpected breakages)

It was this Dask PR: dask/dask#6738. I see the problem described in #482 with that commit, but not with the one before it.

More concretely, the following prints array(3) with that Dask PR, and just 3 with previous versions.

importnumpyasnpimportxarrayasxrimportdask.arrayasdaxr.DataArray.__module__="xarray"# simulate sphinx workaround, which has the effect of Dask not recognising it as xarraydata=np.arange(4)
da.asarray(xr.DataArray(data)).max().compute()

@jrbourbeau

Copy link
Copy Markdown

Gotcha, thanks for the upstream PR in Dask!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-mergeAuto merge label for mergify test flight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tomwhite@jeromekelleher@jrbourbeau@ravwojdyla