Skip to content

Unpin Dask versions now that 2021.3.1 has been released and fixes #482 - #484

Merged
mergify[bot] merged 2 commits into
sgkit-dev:masterfrom
tomwhite:dask-doc-failure
Apr 1, 2021
Merged

Unpin Dask versions now that 2021.3.1 has been released and fixes #482#484
mergify[bot] merged 2 commits into
sgkit-dev:masterfrom
tomwhite:dask-doc-failure

Conversation

@tomwhite

Copy link
Copy Markdown
Member

Fixes#483

@tomwhite

Copy link
Copy Markdown
MemberAuthor

We can either merge this, or wait until the next Dask release with dask/dask#7335 in it.

@jeromekelleher

Copy link
Copy Markdown
Member

Your call @tomwhite

@tomwhite

Copy link
Copy Markdown
MemberAuthor

Dask 2021.3.1 has been released, so we can unpin the Dask version and the build should work.

@tomwhitetomwhite changed the title Don't change DataArray module for Sphinx #482Unpin Dask versions now that 2021.3.1 has been released and fixes #482Mar 29, 2021
@tomwhitetomwhite linked an issue Mar 29, 2021 that may be closed by this pull request
@tomwhitetomwhite added the auto-merge Auto merge label for mergify test flight label Mar 29, 2021
@tomwhite

Copy link
Copy Markdown
MemberAuthor

This just needs an approval now.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #484 (8809f5f) into master (cc57163) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #484 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 34 34 Lines 2642 2632 -10 =========================================
- Hits 2642 2632 -10 
Impacted FilesCoverage Δ
sgkit/variables.py100.00% <0.00%> (ø)
sgkit/io/vcf/csi.py100.00% <0.00%> (ø)
sgkit/io/vcf/tbi.py100.00% <0.00%> (ø)
sgkit/io/vcf/vcf_reader.py100.00% <0.00%> (ø)
sgkit/stats/association.py100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc57163...8809f5f. Read the comment docs.

@mergify
mergifyBot merged commit 2c9a8e0 into sgkit-dev:masterApr 1, 2021
@tomwhite

Copy link
Copy Markdown
MemberAuthor

Thanks Jerome.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-mergeAuto merge label for mergify test flight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation build fails with latest Dask release (2021.3.0)

3 participants

@tomwhite@jeromekelleher@codecov-io