Skip to content

Improved Docker composite action - #99

Merged
omarghatasheh merged 1 commit into
mainfrom
update/docker
Jun 14, 2026
Merged

Improved Docker composite action#99
omarghatasheh merged 1 commit into
mainfrom
update/docker

Conversation

@MusaMisto

@MusaMistoMusaMisto commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Conditional QEMU setup that activates for non-linux/amd64 target platforms
  • Bug Fixes

    • Latest Docker image tag now correctly limited to default branch deployments
    • Push input now properly evaluates as boolean value for consistent behavior
  • Documentation

    • Added detailed usage comments for cache behavior and platform considerations

@MusaMistoMusaMisto self-assigned this Jun 14, 2026
@MusaMistoMusaMisto added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 14, 2026
@coderabbitai

coderabbitaiBot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The docker-build-push composite action is updated to add usage/QEMU/cache documentation comments, introduce a conditional QEMU setup step (skipped for linux/amd64), restrict the latest tag to the default branch, coerce the push input from a string comparison, and reformat success/failure checkpoint notices.

Changes

Docker Build/Push Action Updates

Layer / File(s)Summary
Usage docs, conditional QEMU setup, and Buildx wiring
.github/actions/docker-build-push/action.yml
Adds a usage example header comment and QEMU performance note. Introduces a conditional docker/setup-qemu-action step that only runs when inputs.platforms != 'linux/amd64'. Removes platforms from the docker/setup-buildx-actionwith block.
Cache docs, latest-tag gating, push coercion, and notice formatting
.github/actions/docker-build-push/action.yml
Adds inline cache backend documentation. Changes the latest raw tag to enable={{is_default_branch}}. Coerces the push input via inputs.push == 'true'. Rewrites the success notice title and failure ::error format to include registry, image, version, and checkpoint status values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • omarghatasheh

Poem

🐇 Hop hop, the action's refined,
QEMU skips when amd64's aligned,
The latest tag waits for main's embrace,
Push coerced to truth with string-compare grace,
Notices now say what checkpoints have done —
This bunny approves, the build pipeline's won! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Improved Docker composite action' is vague and generic, using the non-descriptive term 'Improved' without conveying specific details about what was actually changed in the Docker action.Consider a more specific title that highlights the main changes, such as 'Add conditional QEMU setup and fix Docker tag generation in composite action' or 'Enable branch-aware Docker image tagging and improve composite action behavior'.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update/docker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omarghatasheh
omarghatasheh merged commit 4ecd4b1 into mainJun 14, 2026
1 of 2 checks passed
@omarghatasheh
omarghatasheh deleted the update/docker branch June 14, 2026 09:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MusaMisto@omarghatasheh