Skip to content

fix(docs): made sidebar directories scrollable, stylistic changes - #1702

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/docs
Oct 21, 2025
Merged

fix(docs): made sidebar directories scrollable, stylistic changes#1702
waleedlatif1 merged 1 commit into
stagingfrom
fix/docs

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

made sidebar directories scrollable, stylistic changes

Type of Change

  • Bug fix

Testing

Tested manually.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Oct 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
docsReadyReadyPreviewCommentOct 21, 2025 7:04pm

@waleedlatif1
waleedlatif1 merged commit 8597119 into stagingOct 21, 2025
4 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/docs branch October 21, 2025 19:04

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR implements UI improvements for the docs interface, focusing on sidebar scrollability and navbar alignment. The changes increase the sidebar folder's expandable height limit from 2000px to 10000px to accommodate longer directory structures, adjust the navbar search positioning with additional left padding, and reduce the search trigger width slightly for better visual balance.

Key Changes:

  • Increased sidebar folder max-h from 2000px to 10000px for expanded state
  • Added pl-32 padding to center cluster in navbar for improved alignment
  • Reduced search trigger width from 500px to 460px

Minor Considerations:

  • The fixed max-h approach works for most cases but may need refinement if directories exceed 10000px in the future

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple styling changes focused on layout improvements with no logic modifications or breaking changes
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
apps/docs/components/docs-layout/sidebar-components.tsx4/5Increased max-height from 2000px to 10000px to accommodate longer sidebar directories
apps/docs/components/navbar/navbar.tsx5/5Added left padding (pl-32) to center search trigger for better visual alignment
apps/docs/components/ui/search-trigger.tsx5/5Reduced search trigger width from 500px to 460px for better layout balance

Sequence Diagram

sequenceDiagram
participant User
participant Navbar
participant SearchTrigger
participant SidebarFolder
participant DOM
User->>Navbar: Loads docs page
Navbar->>SearchTrigger: Renders centered with pl-32
SearchTrigger->>DOM: Displays 460px wide button
User->>SidebarFolder: Clicks folder toggle
SidebarFolder->>SidebarFolder: setOpen(!open)
SidebarFolder->>DOM: Animates max-h: 0 → 10000px
SidebarFolder->>DOM: Shows nested items with smooth transition
User->>SearchTrigger: Clicks search button
SearchTrigger->>DOM: Dispatches Cmd+K keyboard event
DOM->>User: Opens search modal
Loading

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

className={cn(
'overflow-hidden transition-all duration-200 ease-in-out',
open ? 'max-h-[2000px] opacity-100' : 'max-h-0 opacity-0'
open ? 'max-h-[10000px] opacity-100' : 'max-h-0 opacity-0'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using a fixed max-h value for animation limits scalability. Consider using max-h-screen or implementing proper scrolling with overflow-y-auto if content exceeds 10000px.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/docs-layout/sidebar-components.tsx
Line: 100:100
Comment:
**style:** Using a fixed `max-h` value for animation limits scalability. Consider using `max-h-screen` or implementing proper scrolling with `overflow-y-auto` if content exceeds 10000px.
How can I resolve this? If you propose a fix, please make it concise.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1