Skip to content

v0.4.20: internal request, kb url fixes, docs styling - #1703

Merged
icecrasher321 merged 5 commits into
mainfrom
staging
Oct 21, 2025
Merged

v0.4.20: internal request, kb url fixes, docs styling#1703
icecrasher321 merged 5 commits into
mainfrom
staging

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

fix(internal-req): add internal token to server side (#1700)

fix(kb): add base URL for KB fetches (#1701)

improvement(helm): added additional envvars to helm charts; updated docs (#1695)

fix(docs): made sidebar directories scrollable, stylistic changes (#1702)

@vercel

vercelBot commented Oct 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentPreviewCommentsUpdated (UTC)
docsSkippedSkippedOct 21, 2025 7:09pm

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This release (v0.4.20) includes critical bug fixes and infrastructure improvements across four key areas:

  • Internal API Authentication: Added JWT-based authentication for server-side internal API calls to secure service-to-service communication (tools like Slack and Telegram send message)
  • Knowledge Base URL Handling: Fixed relative URL resolution in KB document processing when called from trigger contexts without base URL
  • Helm Chart Security: Added and documented three new environment variables (INTERNAL_API_SECRET, CRON_SECRET, API_ENCRYPTION_KEY) for production security hardening
  • Documentation UI: Minor styling improvements to sidebar scrolling and search bar positioning

All changes align with the stated bug fixes and improvements. The internal authentication mechanism properly generates short-lived JWT tokens (5-minute expiration) for server-side requests, and the KB fix correctly handles the case where getBaseUrl() is needed for relative URLs.

Confidence Score: 4/5

  • This PR is safe to merge with low risk - mostly bug fixes and documentation updates
  • Score reflects well-tested bug fixes with proper error handling. Minor point deducted because the internal token implementation silently catches token generation errors (logs but doesn't fail), which could mask issues in production. Otherwise, changes are focused, well-documented, and address real bugs.
  • No files require special attention - all changes are straightforward fixes

Important Files Changed

File Analysis

FilenameScoreOverview
apps/sim/tools/index.ts4/5Added internal token authentication for server-side API calls to secure internal routes
apps/sim/lib/knowledge/documents/document-processor.ts5/5Fixed relative URL handling by adding base URL for KB fetches in trigger context
helm/sim/values.yaml5/5Added documentation for new environment variables: INTERNAL_API_SECRET, CRON_SECRET, API_ENCRYPTION_KEY
helm/sim/README.md5/5Updated security documentation with required and optional secrets for production deployments

Sequence Diagram

sequenceDiagram
participant Tool as Tool Executor
participant Auth as Auth Module
participant API as Internal API
participant KB as KB Processor
participant OCR as OCR Service
Note over Tool,API: Internal Request Flow
Tool->>Tool: Detect internal route
Tool->>Auth: Request authentication
Auth->>Auth: Create JWT (5min)
Auth-->>Tool: Return JWT
Tool->>API: HTTP with JWT header
API->>API: Validate request
API-->>Tool: Response
Note over KB,OCR: URL Resolution
KB->>KB: Start parsing
KB->>KB: Check if relative path
KB->>KB: Import getBaseUrl utility
KB->>KB: Build absolute URL
KB->>OCR: HTTP request
OCR-->>KB: Parsed result
Loading

14 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@icecrasher321
icecrasher321 merged commit 9751c9f into mainOct 21, 2025
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@icecrasher321@waleedlatif1