feat(rich-md-editor): table row/col toolbar, raw HTML/footnote support, paste fidelity

[waleedlatif1]

Summary

• Add a table toolbar (add/delete row, add/delete column, toggle header row, delete table) wired to stock @tiptap/extension-table commands — no schema/serializer changes
• Add verbatim snippet nodes for raw HTML blocks, HTML comments, footnotes (def + ref), and inline raw HTML tags — these used to force the entire document read-only; now the raw source is held byte-for-byte and directly editable in place
• Fix an upstream @tiptap/markdown bug found while building this: a custom tokenizer with no explicit start callback corrupts the shared lexer, silently dropping unrelated content (images, tables, mentions) elsewhere in the same document
• Prefer the markdown parser over generic HTML→DOM paste mapping when the plaintext clipboard side looks like markdown, even if an HTML sibling is present
• Fix a stale select-all selection surviving a stream-settle content replace, which permanently highlighted every divider/image after a file regeneration

Type of Change

• New feature
• Bug fix

Testing

223 tests passing in the rich-markdown-editor directory (up from 196), 362 passing across the whole files module. Added integration-level tests exercising the live editor stack (not just headless parse/serialize): table toolbar commands round-tripping through the real serializer, raw snippet node views rendering and being genuinely editable in the DOM, and the stream-settle selection fix locked in at the ProseMirror mechanism level. Biome clean across all 68 files in the directory.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 6, 2026 6:42pm

[cursor]

PR Summary

Medium Risk
Changes core markdown parse/serialize, paste routing, and when files are editable; risk is mitigated by broad tests but regressions in edge-case markdown or clipboard behavior are possible.

Overview
Rich markdown editor gains table editing UI, lossless handling for advanced markdown, and two UX fixes.

Adds a floating table toolbar when the caret is in a table (insert/delete rows and columns, toggle header row, delete table), using stock @tiptap/extension-table commands only.

Introduces verbatim snippet nodes for raw HTML blocks, HTML comments, footnotes (reference + definition), and unsupported inline HTML. These used to trip the round-trip safety gate and lock the whole file read-only; they now store exact source text, serialize byte-for-byte, and are editable in place (with monospace styling and optional “Raw HTML” / “Footnote” badges in the live editor). Custom markdown tokenizers use an explicit start: () => -1 to avoid corrupting the shared lexer.

Paste behavior now runs the internal markdown parser when text/plain looks like markdown, even if text/html is also on the clipboard—so GFM table alignment and other constructs round-trip better; non-markdown HTML pastes still use DOM mapping.

On stream settle, collapses a surviving select-all after setContent so dividers/images are not stuck in the rich-leaf-in-selection highlight after agent regeneration.

Editability gate (round-trip-safety) no longer treats footnotes/HTML comments/raw HTML as stable-loss patterns; tests cover table commands, snippet round-trips, live node views, paste cases, and selection collapse.

^{Reviewed by Cursor Bugbot for commit 0eb68c2. Configure here.}

[greptile-apps]

Greptile Summary

This PR adds table row/column toolbar commands, verbatim snippet nodes for raw HTML blocks/comments/footnotes/inline HTML (replacing the previous read-only gate on those constructs), a markdown-prefer paste strategy, and a stream-settle selection-collapse fix.

• Verbatim snippet nodes (RawHtmlBlock, FootnoteDef, FootnoteRef, RawInlineHtml) hold each construct's exact source text as editable text* content and re-emit it byte-for-byte on serialization; the same design as the existing Mermaid code-block node. The start: () => -1 guard is a documented fix for an upstream @tiptap/markdown bug where omitting start corrupts the shared marked lexer.
• Table toolbar (TableBubbleMenu) is a thin UI layer over stock @tiptap/extension-table commands with no schema changes; resolveAnchor recomputes a fresh DOMRect on every Floating UI update cycle rather than caching by selection key, fixing the scroll-drift bug.
• Paste fidelity now prefers the markdown parser over DOM mapping when the text/plain clipboard side looks like markdown, and the stream-settle handler explicitly collapses any surviving select-all after setContent.

Confidence Score: 5/5

Safe to merge — the verbatim snippet nodes, table toolbar, paste fidelity change, and stream-settle selection fix are all well-contained and thoroughly tested.

All three issues raised in the prior review round (multi-line footnote truncation, unbalanced close-tag scan, stale toolbar scroll position) were resolved in 86d1cdb and are covered by new round-trip tests. The start: () => -1 lexer-guard is correct and documented. The paste-preference change is an intentional design decision appropriate for a markdown-first editor. No data-loss paths, schema breakage, or auth issues were found across any of the 14 changed files.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx	New file introducing four verbatim passthrough nodes. The footnote continuation tokenizer, balanced-close-tag scan, and start: () => -1 lexer-guard are all correct and well-documented. Issues flagged in the prior review thread have been resolved.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/menus/table-menu.tsx	New table bubble-menu component wired to stock tiptap table commands. Cache-free resolveAnchor pattern is correct for Floating UI autoUpdate scroll contract.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.ts	Removes the early-exit when HTML clipboard is present, deferring to DOM mapping only when the plain-text side does not look like markdown. Intentional and correct for a markdown-first editor.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsx	Mounts the TableBubbleMenu and adds an unconditional setTextSelection(doc.content.size) after every stream-settle to collapse any surviving select-all. Comment explains the subtlety correctly.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/round-trip-safety.ts	Removes stable-loss patterns for footnotes/HTML comments/raw HTML tags now that verbatim snippet nodes handle them, with updated comments explaining the migration.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/extensions.ts	Registers the four new verbatim snippet nodes and exposes rawHtmlBlock/footnoteDef as overridable node views in ContentNodeViews.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css	Adds .raw-markdown-block and .raw-markdown-inline styles (monospace, tinted background, pre-wrap) scoped under .rich-markdown-prose. No globals.css edits.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Clipboard paste event] --> B{looksLikeMarkdown text/plain?}
B -- No --> C[ProseMirror DOM path]
B -- Yes --> D[parseMarkdownToDoc insertContent]
E[Markdown source] --> F[marked.js lexer]
F --> G{Token type}
G -- html block --> H[RawHtmlBlock verbatim]
G -- footnoteDef --> I[FootnoteDef verbatim]
G -- footnoteRef --> J[FootnoteRef verbatim]
G -- rawInlineHtml --> K[RawInlineHtml verbatim]
G -- other --> L[Standard tiptap nodes]
H & I --> M[ReactNodeViewRenderer RawBlockView]
J & K --> N[renderHTML span/div]
H & I & J & K --> O[renderMarkdown byte-for-byte]
P[Stream settle] --> Q[setContent new doc]
Q --> R[setTextSelection doc.content.size]
R --> S[setEditable]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Clipboard paste event] --> B{looksLikeMarkdown text/plain?}
B -- No --> C[ProseMirror DOM path]
B -- Yes --> D[parseMarkdownToDoc insertContent]
E[Markdown source] --> F[marked.js lexer]
F --> G{Token type}
G -- html block --> H[RawHtmlBlock verbatim]
G -- footnoteDef --> I[FootnoteDef verbatim]
G -- footnoteRef --> J[FootnoteRef verbatim]
G -- rawInlineHtml --> K[RawInlineHtml verbatim]
G -- other --> L[Standard tiptap nodes]
H & I --> M[ReactNodeViewRenderer RawBlockView]
J & K --> N[renderHTML span/div]
H & I & J & K --> O[renderMarkdown byte-for-byte]
P[Stream settle] --> Q[setContent new doc]
Q --> R[setTextSelection doc.content.size]
R --> S[setEditable]

Loading

_{Reviews (3): Last reviewed commit: "fix(rich-md-editor): fix CI type errors ..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 86d1cdb. Configure here.}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 0eb68c2. Configure here.}