fix(rich-md-editor): raw-HTML-block fragmentation + styling follow-up by waleedlatif1 · Pull Request #5440 · simstudioai/sim

waleedlatif1 · 2026-07-06T20:09:00Z

Summary

Follow-up to #5438 (already merged) — two issues found during manual testing after merge:

Fragmentation bug: RawHtmlBlock delegated to marked's built-in block-HTML tokenizer, which (per CommonMark's HTML-block-type-6 rule) stops at the first blank line. A real <details> with a paragraph inside — the common case — fragmented into a raw chip, an ordinary rendered paragraph, and a second raw chip, stranding real content in between. Fixed with a custom block-level tokenizer that scans to the tag's matching close (reusing the balanced open/close depth-tracking already built for nested inline HTML), spanning blank lines, restricted to CommonMark's own block-tag whitelist (details, div, table, section, etc.) — tags that can legitimately start a paragraph (em, a, span, code, kbd) are left untouched.
Styling: dropped the warning-colored tint on raw HTML/footnote blocks (color-mix with --warning read as an error/warning state, which isn't the right signal) in favor of the same neutral surface as existing code blocks — the hover badge alone now conveys "this is raw, unrendered text".

Type of Change

Bug fix
UI polish

Testing

Added 8 new tests specifically targeting the fragmentation fix (structural node-count assertions, not just string round-trip): multi-paragraph <details>, multi-paragraph <div>, nested same-tag blocks across blank lines, a paragraph starting with a non-whitelisted inline tag (regression guard so <em>/<a> still parse as real marks), a stray non-whitelisted tag alone on a line, an unterminated tag (no crash), a comment spanning blank lines, and a table+code-block adjacency check. 236/236 tests passing in the directory, full tsc --noEmit clean, biome clean.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-06T20:09:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 6, 2026 9:02pm

cursor · 2026-07-06T20:09:10Z

PR Summary

Medium Risk
Changes markdown parse/serialize behavior for block HTML in the file viewer editor; mistakes could mis-bound tags or alter document structure on save, though scope is limited to the rich-markdown verbatim path and is heavily tested.

Overview
Fixes raw HTML block fragmentation in the rich markdown editor: marked’s block-HTML rule used to stop at the first blank line, so constructs like <details> with body paragraphs split into multiple raw chips and normal paragraphs. RawHtmlBlock now registers a custom block tokenizer that, for CommonMark’s block-tag whitelist (details, div, table, etc.), scans to the matching closing tag across blank lines via shared findBalancedCloseEnd logic (with code/fence/comment masking and attribute-aware tag matching). Non-whitelisted tags and unterminated blocks still fall through to marked; void block tags (meta, link, hr) close immediately.

UI: raw HTML/footnote snippets drop the warning-tinted background in favor of the same neutral surface as inline code/pre (hover badge still signals “raw”).

Tests add structural assertions (topLevelTypes) and many edge cases (nested blocks, indented opens, quoted > in attributes, tag mentions in code/comments, void tags, graceful degradation).

^{Reviewed by Cursor Bugbot for commit c043d9c. Configure here.}

greptile-apps · 2026-07-06T20:11:53Z

Greptile Summary

This PR fixes raw HTML handling in the rich markdown editor. The main changes are:

Custom block tokenizing for raw HTML blocks that span blank lines.
Balance scanning that handles indentation, quoted attributes, code regions, comments, and void tags.
Structural tests for raw HTML block parsing and round-tripping.
Neutral raw markdown styling aligned with code block surfaces.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx	Adds the raw HTML block tokenizer and shared balance-scanning helpers for raw HTML preservation.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.test.ts	Adds parser and round-trip coverage for the raw HTML block cases touched by this change.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css	Updates raw markdown block and inline styling to use neutral editor surfaces.

_{Reviews (5): Last reviewed commit: "fix(rich-md-editor): mask HTML comments ..." | Re-trigger Greptile}

waleedlatif1 · 2026-07-06T20:34:30Z

@greptile

waleedlatif1 · 2026-07-06T20:34:33Z

@cursor review

- RawHtmlBlock previously delegated to marked's built-in block-HTML tokenizer, which (per CommonMark's HTML-block-type-6 rule) stops at the first blank line. A real <details> with a paragraph inside — the common case — fragmented into a raw chip, an ordinary rendered paragraph, and a second raw chip, stranding real content in between. - Fixed with a custom block-level tokenizer that scans to the tag's matching close (reusing the balanced open/close depth-tracking already built for nested inline HTML), spanning blank lines, restricted to CommonMark's own block-tag whitelist (details, div, table, section, etc.) so tags that can legitimately start a paragraph (em, a, span, code, kbd) are left untouched. - Dropped the warning-colored tint on raw HTML/footnote blocks (color-mix with --warning read as an error state) in favor of the same neutral surface as existing code blocks — the hover badge alone now signals "this is raw, unrendered text".

…ention edge cases - CommonMark allows up to 3 leading spaces before a block-HTML opening line; the new block tokenizer required column 0, so an indented <details>/<div> still fragmented across blank lines. Fixed by splitting off the leading indent, matching against the rest, and stitching the indent back onto raw. - The open-tag and balanced-close regexes stopped at the first `>`, even inside a quoted attribute value (e.g. data-example="a > b"), producing wrong match lengths and miscounting a same-tag mention inside the quoted value as a real nested tag. Replaced with an attribute-aware pattern that treats a full quoted value (including any interior >) as one unit. - The balanced-tag scan couldn't distinguish real markup from a tag name mentioned inside inline code or a fenced code block. Now masks code regions (same-length filler, positions preserved) before scanning, so a properly-escaped mention (backticks or a fenced example) is never miscounted. A genuinely bare, unescaped mention outside code remains a known, inherent limitation of regex-based tag matching (shared by real HTML parsers given the same ambiguous input) — verified this can never lose data or hang, only reflow to a stable fixpoint on save.

…ce scan - maskCodeRegions's fenced-code regex required fence markers at column 0, so a fence quoted inside a markdown blockquote (each line prefixed with `> `) wasn't recognized, leaving tag mentions inside it visible to the balance scanner. Extended the fence pattern to tolerate an optional blockquote prefix on both the opening and closing fence line. - BLOCK_HTML_TAG_NAMES includes several void elements (link, meta, base, hr, ...) that have no closing tag at all. The block tokenizer only treated an explicit self-closing `/>` as complete, so a void tag without one would scan the rest of the document for a `</meta>` that will never appear, risking a false match on a later same-name mention. Now reuses the existing VOID_TAGS set (already used by the inline tokenizer) to treat these as complete right after the open tag. Also restored `hr` to the whitelist, which was accidentally dropped when transcribing marked's tag list.

waleedlatif1 · 2026-07-06T20:45:32Z

@greptile

waleedlatif1 · 2026-07-06T20:45:35Z

@cursor review

…code masking maskCodeRegions's fence pattern handled a blockquoted fence (`> \`\`\``) but still required the fence marker at column 0 otherwise, missing CommonMark's independent up-to-3-space fence indent tolerance this codebase already relies on elsewhere (FENCE_OPEN/FENCE_CLOSE in markdown-parse.ts). An indented fence's tag-name mention could still end a whitelisted block early. Fixed by combining both allowances in one prefix pattern (zero-or-more blockquote levels, each independently followed by up to 3 more spaces of indent).

waleedlatif1 · 2026-07-06T20:52:46Z

@greptile

waleedlatif1 · 2026-07-06T20:52:49Z

@cursor review

A tag-name mention inside an HTML comment (e.g. ``) inside a whitelisted raw HTML block could still be matched by the balance scan and end the block early, fragmenting it. maskCodeRegions already masked fenced/inline code the same way; extend it to mask comments too.

waleedlatif1 · 2026-07-06T21:02:28Z

@greptile

waleedlatif1 · 2026-07-06T21:02:29Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit c043d9c. Configure here.}

greptile-appsBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx Outdated
Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx Outdated

cursorBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx

vercelBotdeployed to Preview July 6, 2026 20:13 View deployment

waleedlatif1 force-pushed the investigate/markdown-source-editing branch from 0269c2a to 64c7b40Compare July 6, 2026 20:14

vercelBottemporarily deployed to Preview July 6, 2026 20:14 Inactive

vercelBottemporarily deployed to Preview July 6, 2026 20:33 Inactive

greptile-appsBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx Outdated

cursorBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx

waleedlatif1 added 3 commits July 6, 2026 13:43

waleedlatif1 force-pushed the investigate/markdown-source-editing branch from 7ef46eb to 0ea00f3Compare July 6, 2026 20:45

vercelBottemporarily deployed to Preview July 6, 2026 20:45 Inactive

cursorBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx

vercelBottemporarily deployed to Preview July 6, 2026 20:52 Inactive

cursorBot reviewed Jul 6, 2026
View reviewed changes

Comment thread...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet.tsx

vercelBottemporarily deployed to Preview July 6, 2026 21:02 Inactive

cursorBot reviewed Jul 6, 2026
View reviewed changes

waleedlatif1 merged commit 018283b into stagingJul 6, 2026
13 checks passed

waleedlatif1 deleted the investigate/markdown-source-editing branch July 6, 2026 21:10

waleedlatif1 mentioned this pull request Jul 7, 2026
v0.7.24: frontend perf improvements, md editor fixes, mailer fix, tools audit #5458
Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 6, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercelBot commented Jul 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursorBot commented Jul 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-appsBot commented Jul 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

waleedlatif1 commented Jul 6, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented Jul 6, 2026•
edited
Loading

cursorBot commented Jul 6, 2026•
edited
Loading

greptile-appsBot commented Jul 6, 2026•
edited
Loading