product: harden Sky TypeScript message queue - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:234efbfb18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "build": "tsc -p tsconfig.json", | ||
| "typecheck": "tsc -p tsconfig.json --noEmit", | ||
| "test": "node --test test/*.test.mjs" | ||
| "test": "npm run build && node --test dist/queue.test.js" |
There was a problem hiding this comment.
When another src/*.test.ts file is added, the build will compile it into dist, but this command passes only dist/queue.test.js to the runner, so CI will silently omit the new tests. Node's local --help describes --test as “launch test runner on startup”; use test discovery or a compiled-test glob rather than selecting this single positional file.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Product #17 of the SKYCOIN4444 standalone-product plan.
This branch preserves the existing BullMQ/Redis queue implementation while repairing its previously non-executable test setup. Tests now use Node's built-in test runner, the package script builds then executes the compiled tests, and CI enforces typecheck, tests, and a high-severity production dependency audit.
Status: engineering beta. This repository provides queue/envelope primitives and Redis-backed worker wiring; it does not claim managed Redis, durable cross-region HA, exactly-once delivery, tenant isolation, or production deployment.
Merge gate: exact PR head must pass all declared CI checks.