- Notifications
You must be signed in to change notification settings - Fork 0
product: harden Sky TypeScript message queue#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c43407
test: use dependency-free Node test runner
skylerblue333 1f469f8
build: make TypeScript queue tests executable
skylerblue333 234efbf
ci: enforce TypeScript queue tests and dependency audit
skylerblue333 9f9750f
fix: remove npm cache dependency on absent lockfile
skylerblue333 a745713
fix: use constructable Redis export
skylerblue333 0d0654c
fix: align Redis and envelope types
skylerblue333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| import { createEnvelope } from './queue'; | ||
| import assert from "node:assert/strict"; | ||
| import test from "node:test"; | ||
| import { createEnvelope } from "./queue.js"; | ||
| describe('message queue framework', () => { | ||
| it('creates deterministic message envelopes when an id is supplied', () => { | ||
| const message = createEnvelope('payment.completed', { amount: 25 }, 'evt-1'); | ||
| expect(message).toEqual(expect.objectContaining({ id: 'evt-1', type: 'payment.completed', payload: { amount: 25 } })); | ||
| expect(Date.parse(message.createdAt)).not.toBeNaN(); | ||
| }); | ||
| test("creates deterministic message envelopes when an id is supplied", () => { | ||
| const message = createEnvelope("payment.completed", { amount: 25 }, "evt-1"); | ||
| assert.equal(message.id, "evt-1"); | ||
| assert.equal(message.type, "payment.completed"); | ||
| assert.deepEqual(message.payload, { amount: 25 }); | ||
| assert.equal(Number.isNaN(Date.parse(message.createdAt)), false); | ||
| }); | ||
| it('rejects empty message types', () => { | ||
| expect(() => createEnvelope('', {})).toThrow('job type is required'); | ||
| }); | ||
| test("trims job types and rejects blank message types", () => { | ||
| const message = createEnvelope(" feed.index ", {}, "evt-2"); | ||
| assert.equal(message.type, "feed.index"); | ||
| assert.throws(() => createEnvelope(" ", {}), /job type is required/); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When another
src/*.test.tsfile is added, the build will compile it intodist, but this command passes onlydist/queue.test.jsto the runner, so CI will silently omit the new tests. Node's local--helpdescribes--testas “launch test runner on startup”; use test discovery or a compiled-test glob rather than selecting this single positional file.Useful? React with 👍 / 👎.