Uh oh!
There was an error while loading. Please reload this page.
chore: move dependencies to pyproject.toml - #1360
Merged
Merged
Conversation
| rm -rf ./slack_bolt.egg-info | ||
| pip install -U pip && \ | ||
| pip install twine build && \ |
ContributorAuthor
There was a problem hiding this comment.
Minor improvements for consistency
Comment on lines
-15
to
-26
| - package-ecosystem: "npm" | ||
| directory: "/docs" | ||
| schedule: | ||
| interval: "monthly" | ||
| groups: | ||
| docusaurus: | ||
| patterns: | ||
| - "@docusaurus/*" | ||
| react: | ||
| patterns: | ||
| - "react" | ||
| - "react-dom" |
ContributorAuthor
There was a problem hiding this comment.
Cleaning this up because we don't need it anymore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1360 +/- ##
=======================================
Coverage 91.00% 91.00% =======================================
Files 222 222 Lines 7512 7512 =======================================
Hits 6836 6836 Misses 676 676 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Sep 9, 2025
zimeg
left a comment
Member
There was a problem hiding this comment.
@WilliamBergamin LGTM! This is such a nice change to keep things fresh 🚢 🫧
Comment on lines
-15
to
-26
| - package-ecosystem: "npm" | ||
| directory: "/docs" | ||
| schedule: | ||
| interval: "monthly" | ||
| groups: | ||
| docusaurus: | ||
| patterns: | ||
| - "@docusaurus/*" | ||
| react: | ||
| patterns: | ||
| - "react" | ||
| - "react-dom" |
Member
There was a problem hiding this comment.
🫡 praise: Farewell to requirements.txt indeed.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.6 did not support the
pip install .command which installs the dependencies of the project, this is why we defined arequirements.txtfile at the top level. Now that this project does not support python 3.6 we can get ride ofrequirements.txtTesting
CI passes
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.