Skip to content

chore: move dependencies to pyproject.toml#1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 3 commits into from
Sep 9, 2025
Merged

chore: move dependencies to pyproject.toml #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd94759
chore: remove requirements.txt
WilliamBergamin Sep 9, 2025
4a85ec2
small improvements
WilliamBergamin Sep 9, 2025
3b49d08
Dependencies in CI should not be editable
WilliamBergamin Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/dependabot.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,3 @@ updates:
directory: "/"
schedule:
interval: "monthly"
- package-ecosystem: "npm"
directory: "/docs"
schedule:
interval: "monthly"
groups:
docusaurus:
patterns:
- "@docusaurus/*"
react:
patterns:
- "react"
- "react-dom"
Comment on lines -15 to -26

@WilliamBergaminWilliamBergaminSep 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning this up because we don't need it anymore

@zimegzimegSep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 praise: Thanks for catching this!

2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@ jobs:
- name: Install synchronous dependencies
run: |
pip install -U pip
pip install -r requirements.txt
pip install .
pip install -r requirements/testing_without_asyncio.txt
- name: Run tests without aiohttp
run: |
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "slack_bolt"
dynamic = ["version", "readme", "dependencies", "authors"]
dynamic = ["version", "readme", "authors"]
description = "The Bolt Framework for Python"
license = { text = "MIT" }
classifiers = [
Expand All@@ -20,6 +20,7 @@ classifiers = [
"Operating System :: OS Independent",
]
requires-python = ">=3.7"
dependencies = ["slack_sdk>=3.35.0,<4"]


[project.urls]
Expand All@@ -31,7 +32,6 @@ include = ["slack_bolt*"]
[tool.setuptools.dynamic]
version = { attr = "slack_bolt.version.__version__" }
readme = { file = ["README.md"], content-type = "text/markdown" }
dependencies = { file = ["requirements.txt"] }

[tool.distutils.bdist_wheel]
universal = true
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop

@zimegzimegSep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 praise: Farewell to requirements.txt indeed.

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/build_pypi_package.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ cd ${script_dir}/..
rm -rf ./slack_bolt.egg-info

pip install -U pip && \
pip install twine build && \

@WilliamBergaminWilliamBergaminSep 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements for consistency

pip install -U twine build && \
rm -rf dist/ build/ slack_bolt.egg-info/ && \
python -m build --sdist --wheel && \
twine check dist/*
2 changes: 1 addition & 1 deletion scripts/deploy_to_pypi_org.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ cd ${script_dir}/..
rm -rf ./slack_bolt.egg-info

pip install -U pip && \
pip install twine build && \
pip install -U twine build && \
rm -rf dist/ build/ slack_bolt.egg-info/ && \
python -m build --sdist --wheel && \
twine check dist/* && \
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy_to_test_pypi_org.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ cd ${script_dir}/..
rm -rf ./slack_bolt.egg-info

pip install -U pip && \
pip install twine build && \
pip install -U twine build && \
rm -rf dist/ build/ slack_bolt.egg-info/ && \
python -m build --sdist --wheel && \
twine check dist/* && \
Expand Down
2 changes: 1 addition & 1 deletion scripts/format.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,6 @@ script_dir=`dirname $0`
cd ${script_dir}/..

pip install -U pip
pip install -r requirements/tools.txt
pip install -U -r requirements/tools.txt

black slack_bolt/ tests/
2 changes: 1 addition & 1 deletion scripts/install_all_and_run_tests.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ pip uninstall python-lambda

test_target="$1"

pip install -e .
pip install -U -e .

if [[ $test_target != "" ]]
then
Expand Down
2 changes: 1 addition & 1 deletion scripts/run_flake8.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,5 +3,5 @@

script_dir=$(dirname $0)
cd ${script_dir}/.. && \
pip install -r requirements/tools.txt && \
pip install -U -r requirements/tools.txt && \
flake8 slack_bolt/ && flake8 examples/
8 changes: 4 additions & 4 deletions scripts/run_mypy.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@

script_dir=$(dirname $0)
cd ${script_dir}/.. && \
pip install .
pip install -r requirements/async.txt && \
pip install -r requirements/adapter.txt && \
pip install -r requirements/tools.txt && \
pip install -U .
pip install -U -r requirements/async.txt && \
pip install -U -r requirements/adapter.txt && \
pip install -U -r requirements/tools.txt && \
mypy --config-file pyproject.toml
Loading