You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the stopgap @samualtnorman! Following up: the underlying issue #73 no longer reproduces on current main — the TS→JS conversion path was rewritten in #82 (sucrase-based), and JS output for the v2 templates now works end to end. I scaffolded the with-tailwindcss v2 template with JavaScript and vite dev boots and serves SSR HTML with no entry-server.tsx resolution error (details in #73 (comment), where I've closed the issue as fixed).
So suppressing the "Use Typescript?" prompt for v2 is no longer needed — JS is a valid choice for those templates again. Recommend closing this PR; leaving that to you since it's your branch. Thanks again for stepping in with the workaround while this was broken!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a stopgap for #73