Issue with returned values when a second ADS instance is added #12

Open
Open
Issue with returned values when a second ADS instance is added#12

Description

@davgibbs
davgibbs
opened on Jul 31, 2022

Subject of the issue

Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.

Your workbench

  • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
  • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
  • How is the device wired to your platform? via i2c
  • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
  • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.

Steps to reproduce

I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:

Add in a second instance of ADS in the file

ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

Replace:
if (myFlexSensor.begin() == false)
with (to be explicit with the 1-axis sensor at i2c 0x12).
if (myFlexSensor.begin(0x12) == false)

Expected behaviour

The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:

15:11:20.274 -> -93.44
15:11:20.274 -> -93.44
15:11:20.274 -> -92.26
15:11:20.308 -> -89.80
15:11:20.308 -> -88.15

Actual behaviour

The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.

15:12:22.455 -> -177.72
15:12:22.488 -> -176.69
15:12:22.488 -> -177.53
15:12:22.488 -> -187.03
15:12:22.521 -> -187.66

Workaround:

Can either:

  1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
  2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
       blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

      Skip to content
      Issue with returned values when a second ADS instance is added #12
      Open
      Open
      Issue with returned values when a second ADS instance is added#12
      Description
      @davgibbs
      davgibbs
      opened on Jul 31, 2022
      Subject of the issue
      Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
      Your workbench
      • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
      • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
      • How is the device wired to your platform? via i2c
      • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
      • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
      Steps to reproduce
      I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
      Add in a second instance of ADS in the file
      ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

      Replace:
      if (myFlexSensor.begin() == false)
      
with (to be explicit with the 1-axis sensor at i2c 0x12).
      if (myFlexSensor.begin(0x12) == false)
      Expected behaviour
      The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
      15:11:20.274 -> -93.44
      
15:11:20.274 -> -93.44
      
15:11:20.274 -> -92.26
      
15:11:20.308 -> -89.80
      
15:11:20.308 -> -88.15
      Actual behaviour
      The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
      15:12:22.455 -> -177.72
      
15:12:22.488 -> -176.69
      
15:12:22.488 -> -177.53
      
15:12:22.488 -> -187.03
      
15:12:22.521 -> -187.66
      Workaround:
      Can either:
      1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
      2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
      Metadata
      Metadata
      Assignees
      No one assigned
        Labels
        No labels
        No labels
        Type
        No type
        Projects
        No projects
          Milestone
          No milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

          Skip to content
          Issue with returned values when a second ADS instance is added #12
          Open
          Open
          Issue with returned values when a second ADS instance is added#12
          Description
          @davgibbs
          davgibbs
          opened on Jul 31, 2022
          Subject of the issue
          Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
          Your workbench
          • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
          • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
          • How is the device wired to your platform? via i2c
          • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
          • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
          Steps to reproduce
          I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
          Add in a second instance of ADS in the file
          ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

          Replace:
          if (myFlexSensor.begin() == false)
          
with (to be explicit with the 1-axis sensor at i2c 0x12).
          if (myFlexSensor.begin(0x12) == false)
          Expected behaviour
          The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
          15:11:20.274 -> -93.44
          
15:11:20.274 -> -93.44
          
15:11:20.274 -> -92.26
          
15:11:20.308 -> -89.80
          
15:11:20.308 -> -88.15
          Actual behaviour
          The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
          15:12:22.455 -> -177.72
          
15:12:22.488 -> -176.69
          
15:12:22.488 -> -177.53
          
15:12:22.488 -> -187.03
          
15:12:22.521 -> -187.66
          Workaround:
          Can either:
          1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
          2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
          Metadata
          Metadata
          Assignees
          No one assigned
            Labels
            No labels
            No labels
            Type
            No type
            Projects
            No projects
              Milestone
              No milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

              Skip to content
              Issue with returned values when a second ADS instance is added #12
              Open
              Open
              Issue with returned values when a second ADS instance is added#12
              Description
              @davgibbs
              davgibbs
              opened on Jul 31, 2022
              Subject of the issue
              Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
              Your workbench
              • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
              • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
              • How is the device wired to your platform? via i2c
              • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
              • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
              Steps to reproduce
              I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
              Add in a second instance of ADS in the file
              ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

              Replace:
              if (myFlexSensor.begin() == false)
              
with (to be explicit with the 1-axis sensor at i2c 0x12).
              if (myFlexSensor.begin(0x12) == false)
              Expected behaviour
              The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
              15:11:20.274 -> -93.44
              
15:11:20.274 -> -93.44
              
15:11:20.274 -> -92.26
              
15:11:20.308 -> -89.80
              
15:11:20.308 -> -88.15
              Actual behaviour
              The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
              15:12:22.455 -> -177.72
              
15:12:22.488 -> -176.69
              
15:12:22.488 -> -177.53
              
15:12:22.488 -> -187.03
              
15:12:22.521 -> -187.66
              Workaround:
              Can either:
              1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
              2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
              Metadata
              Metadata
              Assignees
              No one assigned
                Labels
                No labels
                No labels
                Type
                No type
                Projects
                No projects
                  Milestone
                  No milestone
                  Relationships
                  None yet
                  Development
                  No branches or pull requests
                  Issue actions
                  
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

                  Skip to content
                  Issue with returned values when a second ADS instance is added #12
                  Open
                  Open
                  Issue with returned values when a second ADS instance is added#12
                  Description
                  @davgibbs
                  davgibbs
                  opened on Jul 31, 2022
                  Subject of the issue
                  Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
                  Your workbench
                  • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
                  • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
                  • How is the device wired to your platform? via i2c
                  • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
                  • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
                  Steps to reproduce
                  I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
                  Add in a second instance of ADS in the file
                  ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

                  Replace:
                  if (myFlexSensor.begin() == false)
                  
with (to be explicit with the 1-axis sensor at i2c 0x12).
                  if (myFlexSensor.begin(0x12) == false)
                  Expected behaviour
                  The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
                  15:11:20.274 -> -93.44
                  
15:11:20.274 -> -93.44
                  
15:11:20.274 -> -92.26
                  
15:11:20.308 -> -89.80
                  
15:11:20.308 -> -88.15
                  Actual behaviour
                  The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
                  15:12:22.455 -> -177.72
                  
15:12:22.488 -> -176.69
                  
15:12:22.488 -> -177.53
                  
15:12:22.488 -> -187.03
                  
15:12:22.521 -> -187.66
                  Workaround:
                  Can either:
                  1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
                  2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
                  Metadata
                  Metadata
                  Assignees
                  No one assigned
                    Labels
                    No labels
                    No labels
                    Type
                    No type
                    Projects
                    No projects
                      Milestone
                      No milestone
                      Relationships
                      None yet
                      Development
                      No branches or pull requests
                      Issue actions
                      
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                      Skip to content
                      Issue with returned values when a second ADS instance is added #12
                      Open
                      Open
                      Issue with returned values when a second ADS instance is added#12
                      Description
                      @davgibbs
                      davgibbs
                      opened on Jul 31, 2022
                      Subject of the issue
                      Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
                      Your workbench
                      • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
                      • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
                      • How is the device wired to your platform? via i2c
                      • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
                      • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
                      Steps to reproduce
                      I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
                      Add in a second instance of ADS in the file
                      ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

                      Replace:
                      if (myFlexSensor.begin() == false)
                      
with (to be explicit with the 1-axis sensor at i2c 0x12).
                      if (myFlexSensor.begin(0x12) == false)
                      Expected behaviour
                      The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
                      15:11:20.274 -> -93.44
                      
15:11:20.274 -> -93.44
                      
15:11:20.274 -> -92.26
                      
15:11:20.308 -> -89.80
                      
15:11:20.308 -> -88.15
                      Actual behaviour
                      The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
                      15:12:22.455 -> -177.72
                      
15:12:22.488 -> -176.69
                      
15:12:22.488 -> -177.53
                      
15:12:22.488 -> -187.03
                      
15:12:22.521 -> -187.66
                      Workaround:
                      Can either:
                      1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
                      2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
                      Metadata
                      Metadata
                      Assignees
                      No one assigned
                        Labels
                        No labels
                        No labels
                        Type
                        No type
                        Projects
                        No projects
                          Milestone
                          No milestone
                          Relationships
                          None yet
                          Development
                          No branches or pull requests
                          Issue actions
                          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                          Skip to content
                          Issue with returned values when a second ADS instance is added #12
                          Open
                          Open
                          Issue with returned values when a second ADS instance is added#12
                          Description
                          @davgibbs
                          davgibbs
                          opened on Jul 31, 2022
                          Subject of the issue
                          Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
                          Your workbench
                          • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
                          • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
                          • How is the device wired to your platform? via i2c
                          • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
                          • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
                          Steps to reproduce
                          I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
                          Add in a second instance of ADS in the file
                          ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

                          Replace:
                          if (myFlexSensor.begin() == false)
                          
with (to be explicit with the 1-axis sensor at i2c 0x12).
                          if (myFlexSensor.begin(0x12) == false)
                          Expected behaviour
                          The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
                          15:11:20.274 -> -93.44
                          
15:11:20.274 -> -93.44
                          
15:11:20.274 -> -92.26
                          
15:11:20.308 -> -89.80
                          
15:11:20.308 -> -88.15
                          Actual behaviour
                          The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
                          15:12:22.455 -> -177.72
                          
15:12:22.488 -> -176.69
                          
15:12:22.488 -> -177.53
                          
15:12:22.488 -> -187.03
                          
15:12:22.521 -> -187.66
                          Workaround:
                          Can either:
                          1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
                          2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
                          Metadata
                          Metadata
                          Assignees
                          No one assigned
                            Labels
                            No labels
                            No labels
                            Type
                            No type
                            Projects
                            No projects
                              Milestone
                              No milestone
                              Relationships
                              None yet
                              Development
                              No branches or pull requests
                              Issue actions
                              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

                              Skip to content
                              Issue with returned values when a second ADS instance is added #12
                              Open
                              Open
                              Issue with returned values when a second ADS instance is added#12
                              Description
                              @davgibbs
                              davgibbs
                              opened on Jul 31, 2022
                              Subject of the issue
                              Hello, thanks for supporting this open source library, it has been really useful for my project. I have a question/observation if anyone could try to reproduce it. It may be a bug or else just my mis-use of the library. There are workarounds, so not of a critical issue. The core of the issue is that "getX()" returns an incorrect value (doubled) when an unrelated begin() call is made in a separate instance.
                              Your workbench
                              • What platform are you using? - Arduino IDE running on Ubuntu with an Arduino Nano 33 BLE
                              • What version of the device are you using? Is there a firmware version? Not sure, firmware not updated since delivery of flex sensor
                              • How is the device wired to your platform? via i2c
                              • How is everything being powered? via the USB serial port on the Arduino and then from the 3.3V output pin on Arduino.
                              • Are there any additional details that may help us help you? I think there may be an issue for this use case with the "begin()" call.
                              Steps to reproduce
                              I want to connect two flex sensors (one 1-axis and one 2-axis) on the same i2c bus. However, I can reproduce this issue using just one 1-axis flex sensor so for ease to reproduce I just had one flex sensor (1-axis) connected to my Arduino Nano. I took the code from the Example1_1Axis_BasicReadings.ino example and edited as below. Full gist with issue is here:
                              Add in a second instance of ADS in the file
                              ADS myFlexSensorTwoAxis;
if (myFlexSensorTwoAxis.begin(0x13) == false) {
Serial.println(F("No sensor two detected. Check wiring. Freezing..."));
}

                              Replace:
                              if (myFlexSensor.begin() == false)
                              
with (to be explicit with the 1-axis sensor at i2c 0x12).
                              if (myFlexSensor.begin(0x12) == false)
                              Expected behaviour
                              The "getX()" in the code below returns an similar value to the angle it is placed at. For example if I put the flex at 90 degrees, the value returned approx 90 degrees. The "myFlexSensorTwoAxis.begin()" for a unrelated sensor does not impact the rest of the code. For example:
                              15:11:20.274 -> -93.44
                              
15:11:20.274 -> -93.44
                              
15:11:20.274 -> -92.26
                              
15:11:20.308 -> -89.80
                              
15:11:20.308 -> -88.15
                              Actual behaviour
                              The flex values returned for ".getX()" are doubled. When I put the flex at 90 degrees, the value returned is 180 degrees. When I put the flex at 180 degrees, the value returned is 360 degrees. The "myFlexSensorTwoAxis.begin()" seems to impact the rest of the code by doubling the values. I'm not sure why this happens.
                              15:12:22.455 -> -177.72
                              
15:12:22.488 -> -176.69
                              
15:12:22.488 -> -177.53
                              
15:12:22.488 -> -187.03
                              
15:12:22.521 -> -187.66
                              Workaround:
                              Can either:
                              1. Switch the order of defining the begin() function. So ensure that the one-axis instance (myFlexSensor) runs the begin() first.
                              2. Remove the "0x13" when running begin() on the myFlexSensorTwoAxis instance. But this is less explicit than including the "0x13". Note that the same issue occurs if 19 decimal is used for hex 0x13 and 18 decimal in place of 0x12.
                              Metadata
                              Metadata
                              Assignees
                              No one assigned
                                Labels
                                No labels
                                No labels
                                Type
                                No type
                                Projects
                                No projects
                                  Milestone
                                  No milestone
                                  Relationships
                                  None yet
                                  Development
                                  No branches or pull requests
                                  Issue actions