Skip to content

Enable list directory async for net framework - #1206

Merged
drieseng merged 6 commits into
sshnet:developfrom
Patrick-3000:enable-list-directory-async-for-net-framework
Oct 14, 2023
Merged

Enable list directory async for net framework#1206
drieseng merged 6 commits into
sshnet:developfrom
Patrick-3000:enable-list-directory-async-for-net-framework

Conversation

@Patrick-3000

@Patrick-3000Patrick-3000 commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

The Nuget package Renci.SshNet is available for .NET Framework. However, if you call ListDirectoryAsync on the SftpClient, you will encounter a MethodNotFoundException only at runtime.

@WojciechNagorskiWojciechNagorski self-assigned this Oct 13, 2023
@WojciechNagorskiWojciechNagorski added this to the vNext milestone Oct 13, 2023
drieseng
drieseng requested changes Oct 13, 2023
View reviewed changes
Comment threadsrc/Renci.SshNet/SftpClient.cs Outdated
asyncResult.Update(offset);
uploadCallback?.Invoke(offset);
});
{

@driesengdriesengOct 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo formatting changes.

@Patrick-3000Patrick-3000Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadsrc/Renci.SshNet/SftpClient.cs Outdated
var asyncResult = new SftpSynchronizeDirectoriesAsyncResult(asyncCallback, state);

ThreadAbstraction.ExecuteThread(() =>
{

@driesengdriesengOct 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent block.

@Patrick-3000Patrick-3000Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadsrc/Renci.SshNet/SftpClient.cs Outdated
var writtenBytes = offset + (ulong) bytesRead;

_sftpSession.RequestWrite(handle, offset, buffer, offset: 0, bytesRead, wait: null, s =>
{

@driesengdriesengOct 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent block.

@Patrick-3000Patrick-3000Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadsrc/Renci.SshNet/Renci.SshNet.csproj
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="7.0.0" />

@driesengdriesengOct 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it conditional so that it only applies to TFMs that do not support IAsyncEnumerable<T> out-of-the-box.

@Patrick-3000Patrick-3000Oct 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment, good idea! Done.

@Rob-Hague

Rob-Hague commented Oct 13, 2023

Copy link
Copy Markdown
Collaborator

The Nuget package Renci.SshNet is available for .NET Framework. However, if you call ListDirectoryAsync on the SftpClient, you will encounter a MethodNotFoundException only at runtime.

ListDirectoryAsync is not included in the compilation for .NET Framework. How are you calling it?

@drieseng
drieseng merged commit 91d1ed2 into sshnet:developOct 14, 2023
@drieseng

drieseng commented Oct 14, 2023

Copy link
Copy Markdown
Member

@Patrick-3000, thanks!

@WojciechNagorskiWojciechNagorski removed their assignment Oct 14, 2023
@WojciechNagorskiWojciechNagorski modified the milestones: vNext, 2023.0.1Oct 14, 2023
WojciechNagorski added a commit that referenced this pull request Oct 14, 2023
@WojciechNagorski@Patrick-3000@Rob-Hague
Move test projects (#1211)
76a6476
* Enable list directory async for net framework (#1206)
* Enable ListDirectoryAsync for .NET Framework
* Removed (now) unused constant.
* Remove placeholder tests (#1183)
* Remove placeholder tests
* Move Reverse perf test to benchmarks project
---------
Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com>
* Fix integration test after moving test projects
---------
Co-authored-by: Patrick-3000 <38472350+Patrick-3000@users.noreply.github.com>
Co-authored-by: Rob Hague <rh@johnstreetcapital.com>
@Patrick-3000
Patrick-3000 deleted the enable-list-directory-async-for-net-framework branch November 2, 2023 09:58
@scott-xu

scott-xu commented Dec 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

SSH.NET.nuspec needs to be updated to add dependency Microsoft.Bcl.AsyncInterfaces 7.0.0 when target net462 and netstandard2.0.
Or shall we just use Renci.SshNet.csproj to build the nuget package?
@WojciechNagorski@drieseng

@Rob-Hague

Rob-Hague commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

Yes, IMO we should remove nuspec and AssemblyInfo and merge them into the csproj

@scott-xu

scott-xu commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

Yes, IMO we should remove nuspec and AssemblyInfo and merge them into the csproj

I drafted a new PR #1256

@scott-xuscott-xu mentioned this pull request Dec 9, 2023
Merged
@WojciechNagorskiWojciechNagorski mentioned this pull request Dec 29, 2023
Closed
@WojciechNagorski

WojciechNagorski commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

This was referenced Aug 12, 2026
Open
Open
Open
Open
This was referenced Aug 12, 2026
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driesengdriesengdrieseng approved these changes
@WojciechNagorskiWojciechNagorskiAwaiting requested review from WojciechNagorskiWojciechNagorski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Patrick-3000@Rob-Hague@drieseng@scott-xu@WojciechNagorski