Skip to content

Merge nuspec and CommonAssemblyInfo into csproj - #1256

Merged
Rob-Hague merged 17 commits into
sshnet:developfrom
scott-xu:generate-nuget-package
Jan 28, 2024
Merged

Merge nuspec and CommonAssemblyInfo into csproj#1256
Rob-Hague merged 17 commits into
sshnet:developfrom
scott-xu:generate-nuget-package

Conversation

@scott-xu

@scott-xuscott-xu commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

Suggest using Nerdbank.GitVersioning after this PR

@scott-xu
scott-xu marked this pull request as ready for review December 2, 2023 05:44
@Rob-HagueRob-Hague mentioned this pull request Dec 2, 2023
4 tasks
Comment threadsrc/Renci.SshNet/Renci.SshNet.csproj Outdated
@Rob-Hague

Rob-Hague commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

Will you also delete https://github.com/sshnet/SSH.NET/blob/develop/build/nuget/SSH.NET.nuspec?

(assuming this works well with sandcastle etc.)

@scott-xu

Copy link
Copy Markdown
CollaboratorAuthor

Will you also delete https://github.com/sshnet/SSH.NET/blob/develop/build/nuget/SSH.NET.nuspec?

(assuming this works well with sandcastle etc.)

I didn't delete the nuspec because I need confirmation from @WojciechNagorski.

@scott-xu

Copy link
Copy Markdown
CollaboratorAuthor

Regarding sandcastle, it would be good to migrate to docfx

@scott-xuscott-xu changed the title Generate nuget package when buildMerge nuspec and CommonAssemblyInfo into csprojDec 3, 2023
Comment threadsrc/Renci.SshNet/Renci.SshNet.csproj Outdated
scott-xuand others added 2 commits December 5, 2023 07:13
@scott-xu

Copy link
Copy Markdown
CollaboratorAuthor

Will you also delete https://github.com/sshnet/SSH.NET/blob/develop/build/nuget/SSH.NET.nuspec?
(assuming this works well with sandcastle etc.)

I didn't delete the nuspec because I need confirmation from @WojciechNagorski.

@WojciechNagorski@drieseng , what do you think? Should we delete SSH.NET.nuspec?

@WojciechNagorski

Copy link
Copy Markdown
Collaborator

@scott-xu I'm sorry that the review is delayed, but I need more time to think and review it thoroughly.

@Rob-Hague

Copy link
Copy Markdown
Collaborator

It looks good. Before (using build/build.proj per the wiki):

Details

image

After (using dotnet pack):

Details

image

I think the next steps are:

  1. Delete the nuspec
  2. Modify build.proj to use dotnet pack instead of nuget.exe

Would it be possible to do these in this PR? That way we don't end up with two different ways to generate the release artifacts, and the new nuget method should integrate seamlessly into the current release process (which will also help with validation).

After that (in another PR) maybe we can call build.proj in CI to generate the artifacts.

@scott-xu
scott-xu marked this pull request as draft January 7, 2024 02:08
@WojciechNagorski

Copy link
Copy Markdown
Collaborator

I will try to find time next week for this PR

This was referenced Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@scott-xu@Rob-Hague@WojciechNagorski@drieseng