Uh oh!
There was an error while loading. Please reload this page.
Merge nuspec and CommonAssemblyInfo into csproj - #1256
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Will you also delete https://github.com/sshnet/SSH.NET/blob/develop/build/nuget/SSH.NET.nuspec? (assuming this works well with sandcastle etc.) |
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
scott-xu
commented
Dec 3, 2023
I didn't delete the nuspec because I need confirmation from @WojciechNagorski. |
scott-xu
commented
Dec 3, 2023
Regarding sandcastle, it would be good to migrate to docfx |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
scott-xu
commented
Dec 9, 2023
@WojciechNagorski@drieseng , what do you think? Should we delete SSH.NET.nuspec? |
WojciechNagorski
commented
Dec 9, 2023
@scott-xu I'm sorry that the review is delayed, but I need more time to think and review it thoroughly. |
Rob-Hague
commented
Jan 6, 2024
It looks good. Before (using build/build.proj per the wiki): After (using I think the next steps are:
Would it be possible to do these in this PR? That way we don't end up with two different ways to generate the release artifacts, and the new nuget method should integrate seamlessly into the current release process (which will also help with validation). After that (in another PR) maybe we can call build.proj in CI to generate the artifacts. |
WojciechNagorski
commented
Jan 7, 2024
I will try to find time next week for this PR |


Suggest using Nerdbank.GitVersioning after this PR