Skip to content

feat: Add uninstall demo/stack feature - #429

Merged
xeniape merged 38 commits into
mainfrom
feat/add-demo-stack-deletion
Apr 14, 2026
Merged

feat: Add uninstall demo/stack feature#429
xeniape merged 38 commits into
mainfrom
feat/add-demo-stack-deletion

Conversation

@xeniape

@xeniapexeniape commented Mar 12, 2026

Copy link
Copy Markdown
Member

Description

Part of #187

This PR adds the uninstall subcommands to demo and stack commands. It implements the MVP features mentioned here #187 (comment)

The flag of skipping operators and CRD deletion was optional and I wasn't sure about the naming or if needs to be one command or two. Can also be just removed, added it because it was not much additional work.

Tested with all current demos/stacks. Some demos have edge cases in the deletion, will document that in the parent issue.

This PR also contains the DEMO/STACK parameter addition for stackabletech/demos#374 (comment) stripped out into #432

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@xeniapexeniape self-assigned this Mar 12, 2026
@xeniapexeniape moved this to Development: Waiting for Review in Stackable EngineeringMar 12, 2026
@Techassi
Techassi self-requested a review March 23, 2026 15:32
@NickLarsenNZNickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringMar 25, 2026
Comment threaddocs/modules/stackablectl/pages/commands/demo.adoc
Comment threaddocs/modules/stackablectl/pages/commands/stack.adoc

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments about namespace deletion.

Comment threadrust/stackable-cockpit/src/platform/demo/spec.rs
Comment threadrust/stackable-cockpit/src/platform/stack/spec.rs

@TechassiTechassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and questions.

Comment threadrust/stackable-cockpit/src/platform/demo/spec.rs
Comment threadrust/stackable-cockpit/src/platform/demo/spec.rs
Comment threadrust/stackable-cockpit/src/platform/demo/spec.rs Outdated
Comment threadrust/stackable-cockpit/src/platform/stack/spec.rs
Comment threadrust/stackable-cockpit/src/platform/manifests.rs
Comment threadrust/stackable-cockpit/src/utils/k8s/client.rs Outdated
Comment threadrust/stackable-cockpit/src/utils/k8s/client.rs Outdated
Comment threadrust/stackablectl/src/cmds/demo.rs Outdated
Comment threadrust/stackablectl/src/cmds/demo.rs Outdated
Comment threadrust/stackablectl/src/cmds/demo.rs Outdated
@xeniape
xeniape requested a review from TechassiMarch 30, 2026 13:31
Techassi
Techassi previously approved these changes Apr 7, 2026
Comment threadrust/stackablectl/src/cmds/demo.rs Outdated
Techassi
Techassi previously approved these changes Apr 14, 2026
Comment threadrust/stackablectl/CHANGELOG.md Outdated
@xeniape
xeniape requested a review from TechassiApril 14, 2026 09:57
@xeniape
xeniape added this pull request to the merge queueApr 14, 2026
Merged via the queue into main with commit b0c771cApr 14, 2026
28 checks passed
@xeniape
xeniape deleted the feat/add-demo-stack-deletion branch April 14, 2026 11:42
@xeniapexeniape moved this from Development: In Review to Development: Done in Stackable EngineeringApr 14, 2026
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringMay 6, 2026
@sbernauersbernauer mentioned this pull request Jul 22, 2026
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@xeniape@NickLarsenNZ@Techassi@lfrancke