Skip to content

feat: Add STACK and DEMO templating parameters - #432

Merged
sbernauer merged 4 commits into
mainfrom
feat/template-stack-and-demo
Mar 18, 2026
Merged

feat: Add STACK and DEMO templating parameters#432
sbernauer merged 4 commits into
mainfrom
feat/template-stack-and-demo

Conversation

@sbernauer

@sbernauersbernauer commented Mar 17, 2026

Copy link
Copy Markdown
Member

Description

Part of #187

Extracted the STACK and DEMO templating out of #429, as it's the IMHO uncontroversial part. It unblocks us from adapting the demo YAMLs already (stackabletech/demos#374).
Doing so I fixed some problems regarding what to make available when, it now has the same semantics as the existing stack and demo labels. I also document them in the README.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

Co-authored-by: Xenia Fischer<xenia.fischer@stackable.tech>
@sbernauersbernauer self-assigned this Mar 17, 2026
@sbernauersbernauer moved this to Development: Waiting for Review in Stackable EngineeringMar 17, 2026
@sbernauer
sbernauer requested a review from a teamMarch 17, 2026 15:26
Comment threadrust/stackable-cockpit/src/platform/manifests.rs
NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 18, 2026

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@NickLarsenNZNickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringMar 18, 2026
@sbernauer
sbernauer added this pull request to the merge queueMar 18, 2026
@sbernauersbernauer moved this from Development: In Review to Development: Done in Stackable EngineeringMar 18, 2026
Merged via the queue into main with commit 2a9d9d5Mar 18, 2026
22 checks passed
@sbernauer
sbernauer deleted the feat/template-stack-and-demo branch March 18, 2026 12:20
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringMar 23, 2026
@xeniapexeniape mentioned this pull request Mar 23, 2026
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer@NickLarsenNZ@lfrancke