Skip to content

WiP: review of the whole codebase - #42

Merged
porridge merged 3 commits into
mainfrom
porridge/review
Apr 14, 2026
Merged

WiP: review of the whole codebase#42
porridge merged 3 commits into
mainfrom
porridge/review

Conversation

@porridge

@porridgeporridge commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Various nitpicks and questions.
Please see just the last commit, the rest is already in:

@porridgeporridge changed the title chore: use an enum for componentWiP: review of the whole codebaseFeb 18, 2026
@porridge
porridge marked this pull request as draft February 18, 2026 10:52
mclasmeier
mclasmeier approved these changes Apr 13, 2026
View reviewed changes

@mclasmeiermclasmeier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Agreeing with all comments -- just one I don't understand 100%.
Maybe it makes sense to rewrite these comments as TODO: ... to make it easier to grep for them.

Comment threadinternal/deployer/operator_olm.go Outdated
Comment threadinternal/deployer/override.go Outdated
Comment threadinternal/env/env.go
Comment threadinternal/helpers/tag.go Outdated
Comment threadinternal/imagecache/imagecache.go Outdated
Comment threadtests/e2e/e2e_test.go Outdated
@porridgeporridge mentioned this pull request Apr 14, 2026
Closed
@porridge
porridge marked this pull request as ready for review April 14, 2026 08:38
@porridge
porridge merged commit 8673ff9 into mainApr 14, 2026
3 checks passed
@porridge
porridge deleted the porridge/review branch April 14, 2026 08:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mclasmeiermclasmeiermclasmeier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@porridge@mclasmeier