Uh oh!
There was an error while loading. Please reload this page.
chore: various improvements - #56
Merged
Merged
Conversation
porridgeforce-pushed
the
porridge/review-simple
branch
from
February 18, 2026 12:25
642e42e to
d7e8794Comparemclasmeier
approved these changes
Feb 18, 2026
mclasmeier
left a comment
Collaborator
There was a problem hiding this comment.
Just few minor comments. 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
These just repeat what is obvious from the line which follows.
These are likely not needed. If they are, synchronization should not be time-based.
porridgeforce-pushed
the
porridge/review-simple
branch
from
April 13, 2026 07:03
d7e8794 to
03a144fCompareporridge
marked this pull request as ready for review
April 13, 2026 07:03
No need for explicit deferred cleanup then.
# Conflicts: # internal/deployer/operator.go
porridgeforce-pushed
the
porridge/review-simple
branch
from
April 13, 2026 07:09
03a144f to
9d6b88cComparemclasmeier
approved these changes
Apr 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review commit-by commit.
Each represents a self-contained change and each of them should be merge-worthy as is.