Uh oh!
There was an error while loading. Please reload this page.
[6.x] Fix breadcrumb dropdown with plurals including apostrophes. - #12602
Merged
Conversation
As described in issue
Uh oh!
There was an error while loading. Please reload this page.
jackmcdade
commented
Sep 29, 2025
Member
Nice one, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Dutch language, the term 'Pages' translates into 'Pagina's' (reckon the apostrophe in the Dutch word. We need the apostrophe to keep the open a at the end of the word 'long' else the sound would change.).
However, with the new breadcrumbs dropdown introduced, this actually breaks the possibility to edit an entry in the Pages-collection in the Dutch language.
See these screenshots:
It is caused by line 26 of this code:
2f74fbd#diff-06ff751bfeceb5fa3d7f99a7281d9308f41573791314d2da1e499b87dff7e95aR25
If I change that line to:
aria-label="'{{ __('Options for') }} {{ __($breadcrumb->text()) }}'"(so without the : (what was the reason to include it?))it resolves correctly, so I guess this would do the trick (see also the difference with for the 'options for'-line)
Of course this would also fix it for other collections that would include an apostrophe in their plurals.