Uh oh!
There was an error while loading. Please reload this page.
[6.x] More dropdown breadcrumb fixes - #12622
Closed
Frank-L93 wants to merge 2 commits into
Closed
Conversation
Aria-label in the if($breadcrumb->hasLinks)-part caused more JS-errors
Updated the aria-label for the createUrl. 'Create New' and createLabel() is double, as the createLabel already will output 'Create'
Member
This is resolved in #12610. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As earlier explained in #12602


I faced it again with a second collection added, then the Aria-label in the if($breadcrumb->hasLinks)-part caused the same JS-errors
So therefore this PR to solve this issue. I also took the liberty to change the text order in the aria-labels to make it consistent with the other ones, and the 'Create new' is double for the createLabel (resolving into 'Create new Create Collection'), so I removed that (although, maybe the idea was to have it like 'Create new Collection', but couldn't figure out a nice way to just have the 'label' be rendered instead of the createLabel, so I think this the right approach).
After the changes it resolves without errors, to this Accessibility Tree view (in Dutch):
