Skip to content

Fix #664 fixing param s in AB-join mode - #665

Merged
seanlaw merged 1 commit into
stumpy-dev:mainfrom
NimaSarajpoor:param_s
Sep 1, 2022
Merged

Fix #664 fixing param s in AB-join mode#665
seanlaw merged 1 commit into
stumpy-dev:mainfrom
NimaSarajpoor:param_s

Conversation

@NimaSarajpoor

@NimaSarajpoorNimaSarajpoor commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

This PR resolves the issue raised in #664. When s=None and T_B is not None, the value of s remains None in scrump and prescrump and their non-normalized versions. I used the suggestion provided by @seanlaw (in #664) to fix the issue.

@codecov-commenter

codecov-commenter commented Sep 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #665 (3700791) into main (d1469aa) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@ Coverage Diff @@## main #665 +/- ##
==========================================
- Coverage 99.89% 99.87% -0.02% 
==========================================
Files 80 80 Lines 11451 11455 +4 ==========================================
+ Hits 11439 11441 +2 - Misses 12 14 +2 
Impacted FilesCoverage Δ
stumpy/scraamp.py99.29% <66.66%> (-0.71%)⬇️
stumpy/scrump.py99.31% <66.66%> (-0.69%)⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NimaSarajpoor

NimaSarajpoor commented Sep 1, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I think we got the imprecision issue again, caused by identical sequence (see PR #657)

@seanlaw
seanlaw merged commit bcc5b02 into stumpy-dev:mainSep 1, 2022
@seanlaw

Copy link
Copy Markdown
Contributor

Thanks for addressing this @NimaSarajpoor!

@NimaSarajpoorNimaSarajpoor mentioned this pull request Sep 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NimaSarajpoor@codecov-commenter@seanlaw