Skip to content

Fix #664 fixing coverage - #666

Merged
seanlaw merged 3 commits into
stumpy-dev:mainfrom
NimaSarajpoor:param_s
Sep 1, 2022
Merged

Fix #664 fixing coverage#666
seanlaw merged 3 commits into
stumpy-dev:mainfrom
NimaSarajpoor:param_s

Conversation

@NimaSarajpoor

Copy link
Copy Markdown
Collaborator

This PR fixes the coverage issue raised in the PR #665, related to issue #664.

@NimaSarajpoor

Copy link
Copy Markdown
CollaboratorAuthor

@seanlaw
When you notice all tests are passing, you may want to take a look and see if the inline comments are okay or not. I did as follows:

else # pragma: no cover # AB-join 

I think it fixes the coverage; however, I am not sure if you prefer to remove the second comment # AB-join or not.

@codecov-commenter

codecov-commenter commented Sep 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #666 (859a3a1) into main (bcc5b02) will increase coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## main #666 +/- ##
==========================================
+ Coverage 99.87% 99.89% +0.01% 
==========================================
Files 80 80 Lines 11455 11453 -2 ==========================================
Hits 11441 11441 + Misses 14 12 -2 
Impacted FilesCoverage Δ
stumpy/scraamp.py100.00% <ø> (+0.70%)⬆️
stumpy/scrump.py100.00% <ø> (+0.68%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seanlaw

Copy link
Copy Markdown
Contributor

When you notice all tests are passing, you may want to take a look and see if the inline comments are okay or not

Yeah, I noticed it originally and it didn't bother me a ton and I would've done the same thing as you. 😄

@seanlaw
seanlaw merged commit 11bb86d into stumpy-dev:mainSep 1, 2022
@seanlaw

Copy link
Copy Markdown
Contributor

Thanks @NimaSarajpoor

@NimaSarajpoor
NimaSarajpoor deleted the param_s branch September 4, 2023 03:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NimaSarajpoor@codecov-commenter@seanlaw