Skip to content

feat: allow amr claim to be array of strings or objects - #2274

Merged
cemalkilic merged 4 commits into
masterfrom
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged

feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom
cemal/feat-loose-amr-claim-check

Conversation

@cemalkilic

@cemalkiliccemalkilic commented Dec 1, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.

  • Test Coverage: Added two new test cases:
    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)

Motivation

This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.

Testing

All tests pass, including:

  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects

Backward Compatibility

Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.

@cemalkilic
cemalkilic requested a review from a team as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot reviewed Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls

coveralls commented Dec 1, 2025•
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20258077816

Details

  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls

hf
hf approved these changes Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed the cemal/feat-loose-amr-claim-check branch from 8ffca8c to b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic mentioned this pull request Dec 17, 2025
Merged
6 tasks
@cemalkilic
cemalkilic merged commit 607da43 into masterDec 17, 2025
6 checks passed
@cemalkilic
cemalkilic deleted the cemal/feat-loose-amr-claim-check branch December 17, 2025 15:18
@github-actionsgithub-actionsBot mentioned this pull request Dec 11, 2025
Merged
hf added a commit that referenced this pull request Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf mentioned this pull request Jan 12, 2026
Merged
cemalkilic pushed a commit that referenced this pull request Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit that referenced this pull request Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic mentioned this pull request Jan 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat: allow amr claim to be array of strings or objects by cemalkilic · Pull Request #2274 · supabase/auth · GitHub
Skip to content
feat: allow amr claim to be array of strings or objects - #2274
Merged
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Dec 17, 2025
Merged
feat: allow amr claim to be array of strings or objects#2274
cemalkilic merged 4 commits into
masterfrom 
cemal/feat-loose-amr-claim-check
Conversation
@cemalkilic
@cemalkiliccemalkilic
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
This PR loosens the validation for the amr (Authentication Method Reference) claim in custom access token hooks to accept both array of strings and array of objects, instead of only array of objects.
  • Test Coverage: Added two new test cases:

    • Modify amr to be array of strings - Verifies that amr as an array of strings passes validation
    • Modify amr to be array of objects - Verifies that amr as an array of objects still works (backward compatibility)
Motivation
This change provides more flexibility for custom access token hooks. RFC-8176 requires amr to be array of strings.
Testing
All tests pass, including:
  • Existing custom access token tests
  • New test for amr as array of strings
  • New test for amr as array of objects
Backward Compatibility
Fully backward compatible - The change only adds support for an additional format. Existing hooks that return amr as an array of objects will continue to work without any changes.
@cemalkilic
cemalkilic
requested a review
from a team
as a code ownerDecember 1, 2025 06:13
depthfirst-app[bot]
depthfirst-appBot
reviewed
Dec 1, 2025
View reviewed changes
Comment threadinternal/tokens/service.go
@coveralls
coveralls
commented
Dec 1, 2025•

edited

Loading

Copy link


Copy Markdown

Pull Request Test Coverage Report for Build 20258077816
Details
  • 21 of 28(75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 68.536%
Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/tokens/service.go212875.0%
TotalsCoverage Status
Change from base Build 20136212429:0.009%
Covered Lines:14703
Relevant Lines:21453
💛 - Coveralls
hf
hf
approved these changes
Dec 1, 2025
View reviewed changes
@cemalkilic
cemalkilicforce-pushed
the
cemal/feat-loose-amr-claim-check
branch
from
8ffca8c to
b4cb5fbCompareDecember 11, 2025 04:52
@cemalkiliccemalkilic
mentioned this pull request
Dec 17, 2025
 Merged

6 tasks
@cemalkilic
cemalkilic
merged commit 607da43
into
masterDec 17, 2025

6 checks passed

@cemalkilic
cemalkilic
deleted the

cemal/feat-loose-amr-claim-check

branch
December 17, 2025 15:18
@github-actionsgithub-actionsBot
mentioned this pull request
Dec 11, 2025
 Merged

hf added a commit
that referenced
this pull request
Jan 12, 2026
@hf
Revert "feat: allow amr claim to be array of strings or objects (#2274)"
2dbfec9
This reverts commit 607da43.
@hfhf
mentioned this pull request
Jan 12, 2026
 Merged

cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit
that referenced
this pull request
Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit
that referenced
this pull request
Jan 19, 2026
@cemalkilic
feat: allow amr claim to be array of strings or objects (#2274)
77d4d24
## Summary
This PR loosens the validation for the `amr` (Authentication Method
Reference) claim in custom access token hooks to accept both array of
strings and array of objects, instead of only array of objects.
- **Test Coverage**: Added two new test cases:
- Modify amr to be array of strings - Verifies that `amr` as an array of
strings passes validation
- Modify amr to be array of objects - Verifies that `amr` as an array of
objects still works (backward compatibility)
## Motivation
This change provides more flexibility for custom access token hooks.
[RFC-8176
](https://www.rfc-editor.org/rfc/rfc8176.html#section-1)requires `amr`
to be array of strings.
## Testing
All tests pass, including:
- Existing custom access token tests
- New test for `amr` as array of strings
- New test for `amr` as array of objects
## Backward Compatibility
**Fully backward compatible** - The change only adds support for an
additional format. Existing hooks that return `amr` as an array of
objects will continue to work without any changes.
@cemalkiliccemalkilic
mentioned this pull request
Jan 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@depthfirst-appdepthfirst-app[bot]depthfirst-app[bot] left review comments
@hfhfhf approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@cemalkilic@coveralls@hf