') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: check each type independently by cstockton · Pull Request #2290 · supabase/auth · GitHub
Skip to content

fix: check each type independently - #2290

Merged
cstockton merged 1 commit into
masterfrom
cs/migrations-fix-for-add-mfa
Dec 11, 2025
Merged

fix: check each type independently#2290
cstockton merged 1 commit into
masterfrom
cs/migrations-fix-for-add-mfa

Conversation

@cstockton

@cstocktoncstockton commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Because type creation resides in the do block it is all or nothing. When it's not a duplicate object that behavior is appropriate, but if it's because one of the types already exists then you will fail the creation of the other types.

For example:

  • aal_level type already exists
  • factor_status & factor_type are missing

Currently this would prevent factor_status & factor_type from ever getting created.

Chris Stockton
fix: check each type independently
7e125dd
Because type creation resides in the do block it is all or
nothing. When it's not a duplicate object that behavior is
appropriate, but if it's because one of the types already
exists then you will fail the creation of the other types.
For example:
* `aal_level` type already exists
* `factor_status` & `factor_type` are missing
Currently this would prevent `factor_status` & `factor_type` from
ever getting created.
@cstockton
cstockton requested a review from a team as a code ownerDecember 10, 2025 23:35
@coveralls

coveralls commented Dec 10, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20116748949

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.527%
TotalsCoverage Status
Change from base Build 20114365630:0.0%
Covered Lines:14682
Relevant Lines:21425
💛 - Coveralls

fadymak
fadymak reviewed Dec 11, 2025
View reviewed changes
Comment threadmigrations/20221003041349_add_mfa_schema.up.sql
@cstockton
cstockton merged commit d9de0af into masterDec 11, 2025
10 checks passed
@cstockton
cstockton deleted the cs/migrations-fix-for-add-mfa branch December 11, 2025 14:19
@github-actionsgithub-actionsBot mentioned this pull request Dec 10, 2025
Merged
hf added a commit that referenced this pull request Jan 12, 2026
@hf
Revert "fix: check each type independently (#2290)"
a65d2c6
This reverts commit d9de0af.
@hfhf mentioned this pull request Jan 12, 2026
Merged
cemalkilic pushed a commit that referenced this pull request Jan 12, 2026
@hf@depthfirst-app
feat: reset main branch to 2.185.0 (#2325)
b9d0500
Resets the main branch (`master`) to have the same changeset as 2.184.0
but under 2.185.0.
Original release please notes:
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---------
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Jan 12, 2026
@github-actions
chore(master): release 2.185.0 (#2287)
711763c
🤖 I have created a release *beep* *boop*
---
##
[2.185.0](v2.184.0...v2.185.0)
(2026-01-12)
### Features
* Add Sb-Forwarded-For header and IP-based rate limiting
([#2295](#2295))
([e8f679b](e8f679b))
* allow amr claim to be array of strings or objects
([#2274](#2274))
([607da43](607da43))
* reset main branch to 2.185.0
([#2325](#2325))
([b9d0500](b9d0500))
* Treat rate limit header value as comma-separated list
([#2282](#2282))
([5f2e279](5f2e279))
### Bug Fixes
* additional provider and issuer checks
([#2326](#2326))
([cb79a74](cb79a74))
* check each type independently
([#2290](#2290))
([d9de0af](d9de0af))
* fix the wrong error return value
([#1950](#1950))
([e2dfb5d](e2dfb5d))
* **indexworker:** remove pg_trgm extension
([#2301](#2301))
([c553b10](c553b10))
* **oauth-server:** allow custom URI schemes in client redirect URIs
([#2298](#2298))
([ea72f57](ea72f57))
* tighten email validation rules
([#2304](#2304))
([33bb372](33bb372))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bewinxed pushed a commit that referenced this pull request Jan 19, 2026
@cstocktonChris Stockton
fix: check each type independently (#2290)
af0988f
Because type creation resides in the do block it is all or nothing. When
it's not a duplicate object that behavior is appropriate, but if it's
because one of the types already exists then you will fail the creation
of the other types.
For example:
* `aal_level` type already exists
* `factor_status` & `factor_type` are missing
Currently this would prevent `factor_status` & `factor_type` from ever
getting created.
Co-authored-by: Chris Stockton <chris.stockton@supabase.io>
@cemalkiliccemalkilic mentioned this pull request Jan 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fadymakfadymakfadymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cstockton@coveralls@fadymak