fix(stack): reserve ports through service startup by jgoux · Pull Request #6045 · supabase/cli

jgoux · 2026-08-03T16:29:40Z

Stack layer 5 of 7, based on #6044.

Closes the lazy-start port race by replacing probe-only allocation with real OS leases:

holds selected ports until the owning proxy or service is ready to bind
releases only the process-graph dependency closure being started
reserves daemon-selected ports with the same lifecycle
cleans up partial allocations and all remaining listeners on disposal
covers concurrent stack allocation and lease retention

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:706b171d88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:a6e072975c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:fad354d893

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:4265a74ba6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c2cdb81572

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac00e70644

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:3ea143a742

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1f4a18a420

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9f2f7d4a62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:868f236aba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1ebb475a62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:cc5effc281

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:963914941c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:8d6ede95b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jgoux · 2026-08-05T07:02:23Z

Superseded by #6070 in the simplified replacement stack #6069 → #6070 → #6071. Port reservation remains tied to actual spawn/bind boundaries, while the host-wide managed lock and release-file spawn gate were intentionally removed. Every remaining review thread has been answered and resolved. Closing this PR so review continues on the replacement.

Consolidates the complete lazy-stack v2 implementation and its architecture hardening into one reviewable change. The implementation replaces the earlier user-space coordination protocols with explicit ownership boundaries and operating-system primitives: - centralizes Docker and native artifact policy in one service catalog - publishes complete native caches through private staging directories and atomic rename - models lifecycle intent directly on each service as inactive, running, or explicitly stopped - activates HTTP services at the existing proxy boundary while keeping direct-listener services eager - reserves real TCP ports until each service reaches its spawn boundary - gives foreground and detached stacks the same allocation, readiness, and lifecycle behavior - enables lazy startup for CLI-managed local stacks while preserving eager startup as the package default The hardening pass makes each service's stable state stream the single lifecycle coordination primitive, removes generation-specific waiter and relaunch machinery, keeps healthy requests off the global lifecycle lock, starts independent eager roots concurrently, recovers incomplete artifact-cache destinations, and makes service port mappings exhaustive. This keeps the simpler v2 architecture while closing the highest-impact concurrency, recovery, and shutdown races identified during review. Realtime remains eager because the HTTP proxy does not bridge its WebSocket traffic, and concurrent artifact downloaders may duplicate work while still publishing through an atomic winner. Supersedes supabase#6041 Supersedes supabase#6042 Supersedes supabase#6043 Supersedes supabase#6044 Supersedes supabase#6045 Supersedes supabase#6046 Supersedes supabase#6047 Supersedes supabase#6069 Supersedes supabase#6070 Supersedes supabase#6071

This was referenced Aug 3, 2026
fix(stack): preserve lazy lifecycle in detached mode #6046
Closed
fix(stack): harden service artifact resolution #6041
Closed

7ttp mentioned this pull request Aug 3, 2026
test(stack): deflake parallel stacks #6052
Merged

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from c0631bd to 37acb4bCompare August 4, 2026 07:43

jgoux force-pushed the lazy-stack/05-port-leases branch from e273d2d to 706b171Compare August 4, 2026 07:43

jgoux marked this pull request as ready for review August 4, 2026 07:50

jgoux requested a review from a team as a code owner August 4, 2026 07:50

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated
Comment threadpackages/stack/src/daemon.ts

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 37acb4b to 8e31b5cCompare August 4, 2026 08:04

jgoux force-pushed the lazy-stack/05-port-leases branch from 706b171 to a6e0729Compare August 4, 2026 08:05

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/stack/src/PortAllocator.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 8e31b5c to 0398257Compare August 4, 2026 08:48

jgoux force-pushed the lazy-stack/05-port-leases branch from a6e0729 to fad354dCompare August 4, 2026 08:48

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated
Comment threadpackages/stack/src/createStack.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 0398257 to c18d586Compare August 4, 2026 09:32

jgoux force-pushed the lazy-stack/05-port-leases branch from fad354d to 4265a74Compare August 4, 2026 09:32

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/process-compose/src/Orchestrator.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 4265a74 to c2cdb81Compare August 4, 2026 09:41

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from c18d586 to 5fbe0b5Compare August 4, 2026 09:41

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/daemon.ts Outdated
Comment threadpackages/stack/src/createStack.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 5fbe0b5 to 1b41b91Compare August 4, 2026 10:20

jgoux force-pushed the lazy-stack/05-port-leases branch from c2cdb81 to ac00e70Compare August 4, 2026 10:20

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/stack/src/StackLifecycleCoordinator.ts

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 1b41b91 to 2d2fccdCompare August 4, 2026 10:37

jgoux force-pushed the lazy-stack/05-port-leases branch from ac00e70 to 3ea143aCompare August 4, 2026 10:37

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts Outdated
Comment threadpackages/stack/src/ManagedPortLock.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 2d2fccd to 3be802bCompare August 4, 2026 11:07

jgoux force-pushed the lazy-stack/05-port-leases branch from 3ea143a to 1f4a18aCompare August 4, 2026 11:07

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 3be802b to 2fde245Compare August 4, 2026 11:25

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/createStack.ts
Comment threadpackages/stack/src/createStack.ts Outdated
Comment threadpackages/stack/src/ManagedPortLock.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 3428039 to 7304cfaCompare August 4, 2026 12:12

jgoux force-pushed the lazy-stack/05-port-leases branch from 9f2f7d4 to 868f236Compare August 4, 2026 12:12

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts
Comment threadpackages/stack/src/ManagedPortLock.ts Outdated
Comment threadpackages/process-compose/src/Orchestrator.ts

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 7304cfa to a4277ceCompare August 4, 2026 12:48

jgoux force-pushed the lazy-stack/05-port-leases branch from 868f236 to 1ebb475Compare August 4, 2026 12:48

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from a4277ce to 7e4eedeCompare August 4, 2026 12:58

jgoux force-pushed the lazy-stack/05-port-leases branch from 1ebb475 to cc5effcCompare August 4, 2026 12:58

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts
Comment threadpackages/stack/src/ManagedPortLock.ts
Comment threadpackages/stack/src/createStack.ts Outdated

depthfirst-appBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts Outdated

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 7e4eede to 78e2903Compare August 4, 2026 13:20

jgoux force-pushed the lazy-stack/05-port-leases branch from cc5effc to 9639149Compare August 4, 2026 13:20

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/process-compose/src/ServiceTransition.ts

jgoux added 8 commits August 4, 2026 15:56

fix(stack): reserve ports through service startup
9d23fdb

fix(stack): harden managed port lock acquisition
8bba36c

fix(stack): fail interrupted supervised startup
1ad28fc

fix(stack): re-reserve ports across service restarts
2662171

fix(stack): harden managed port lock handoff
8d3df92

fix(stack): publish complete lock generations atomically
3d45f36

fix(stack): clean up interrupted lock installation
bf4fa2e

fix(process-compose): fail services on pre-start errors
8d6ede9

jgoux force-pushed the lazy-stack/05-port-leases branch from 9639149 to 8d6ede9Compare August 4, 2026 14:06

jgoux force-pushed the lazy-stack/04-realtime-websocket branch from 78e2903 to ac2d69aCompare August 4, 2026 14:06

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts
Comment threadpackages/process-compose/src/supervisor-runtime.ts
Comment threadpackages/process-compose/src/Orchestrator.ts
Comment threadpackages/stack/src/createStack.ts
Comment threadpackages/process-compose/src/Orchestrator.ts

jgoux mentioned this pull request Aug 5, 2026
feat(stack): add lazy service lifecycle #6070
Closed

jgoux closed this Aug 5, 2026

jgoux mentioned this pull request Aug 5, 2026
feat(stack): add hardened lazy service lifecycle #6072
Merged

Uh oh!

Conversation

jgoux commented Aug 3, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!