fix(stack): preserve lazy lifecycle in detached mode by jgoux · Pull Request #6046 · supabase/cli

jgoux · 2026-08-03T16:29:49Z

Stack layer 6 of 7, based on #6045.

Makes daemon-backed stacks preserve foreground lazy lifecycle semantics:

tracks the real activated dependency closure and clears it across restarts
fails readiness checks immediately outside the running phase or for dormant lazy services
delegates remote readiness to dedicated daemon endpoints
preserves typed lifecycle errors across the HTTP boundary
validates and bounds the parent-child startup handshake

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:64bea19f14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e2dd44f795

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:f130bfd263

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:fb580862d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e4738fa597

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:67ad946444

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:e1d2245753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:f1319efa81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:938ee92d68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:038fc012de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d486dd6436

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jgoux · 2026-08-05T07:02:24Z

Superseded by #6070 in the simplified replacement stack #6069 → #6070 → #6071. The daemon now owns port allocation and atomically claims live state in the configured stack directory, without a second state-lock lifecycle. Every remaining review thread has been answered and resolved. Closing this PR so review continues on the replacement.

Consolidates the complete lazy-stack v2 implementation and its architecture hardening into one reviewable change. The implementation replaces the earlier user-space coordination protocols with explicit ownership boundaries and operating-system primitives: - centralizes Docker and native artifact policy in one service catalog - publishes complete native caches through private staging directories and atomic rename - models lifecycle intent directly on each service as inactive, running, or explicitly stopped - activates HTTP services at the existing proxy boundary while keeping direct-listener services eager - reserves real TCP ports until each service reaches its spawn boundary - gives foreground and detached stacks the same allocation, readiness, and lifecycle behavior - enables lazy startup for CLI-managed local stacks while preserving eager startup as the package default The hardening pass makes each service's stable state stream the single lifecycle coordination primitive, removes generation-specific waiter and relaunch machinery, keeps healthy requests off the global lifecycle lock, starts independent eager roots concurrently, recovers incomplete artifact-cache destinations, and makes service port mappings exhaustive. This keeps the simpler v2 architecture while closing the highest-impact concurrency, recovery, and shutdown races identified during review. Realtime remains eager because the HTTP proxy does not bridge its WebSocket traffic, and concurrent artifact downloaders may duplicate work while still publishing through an atomic winner. Supersedes supabase#6041 Supersedes supabase#6042 Supersedes supabase#6043 Supersedes supabase#6044 Supersedes supabase#6045 Supersedes supabase#6046 Supersedes supabase#6047 Supersedes supabase#6069 Supersedes supabase#6070 Supersedes supabase#6071

This was referenced Aug 3, 2026
feat(cli): enable lazy local stack startup #6047
Closed
fix(stack): harden service artifact resolution #6041
Closed

jgoux force-pushed the lazy-stack/05-port-leases branch from e273d2d to 706b171Compare August 4, 2026 07:43

jgoux force-pushed the lazy-stack/06-detached-parity branch from f1e0c43 to 64bea19Compare August 4, 2026 07:43

jgoux marked this pull request as ready for review August 4, 2026 07:51

jgoux requested a review from a team as a code owner August 4, 2026 07:51

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated
Comment threadpackages/stack/src/layers.ts Outdated
Comment threadpackages/stack/src/RemoteStack.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 706b171 to a6e0729Compare August 4, 2026 08:05

jgoux force-pushed the lazy-stack/06-detached-parity branch from 64bea19 to 89af0f2Compare August 4, 2026 08:05

jgoux force-pushed the lazy-stack/05-port-leases branch from a6e0729 to fad354dCompare August 4, 2026 08:48

jgoux force-pushed the lazy-stack/06-detached-parity branch from 89af0f2 to e2dd44fCompare August 4, 2026 08:48

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/DaemonServer.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from fad354d to 4265a74Compare August 4, 2026 09:32

jgoux force-pushed the lazy-stack/06-detached-parity branch from e2dd44f to f130bfdCompare August 4, 2026 09:32

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/DaemonServer.ts Outdated
Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated
Comment threadpackages/stack/src/RemoteStack.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 4265a74 to c2cdb81Compare August 4, 2026 09:41

jgoux force-pushed the lazy-stack/06-detached-parity branch 2 times, most recently from ce21004 to fb58086Compare August 4, 2026 10:20

jgoux force-pushed the lazy-stack/05-port-leases branch from c2cdb81 to ac00e70Compare August 4, 2026 10:20

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/docs/detach-mode.md
Comment threadpackages/stack/src/DaemonServer.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from ac00e70 to 3ea143aCompare August 4, 2026 10:37

jgoux force-pushed the lazy-stack/06-detached-parity branch from fb58086 to e4738faCompare August 4, 2026 10:37

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts

jgoux force-pushed the lazy-stack/05-port-leases branch from 3ea143a to 1f4a18aCompare August 4, 2026 11:07

jgoux force-pushed the lazy-stack/06-detached-parity branch from e4738fa to d958c83Compare August 4, 2026 11:07

jgoux force-pushed the lazy-stack/05-port-leases branch from 1f4a18a to 2bd9fd1Compare August 4, 2026 11:25

jgoux force-pushed the lazy-stack/06-detached-parity branch from d958c83 to 67ad946Compare August 4, 2026 11:25

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/daemon.ts Outdated
Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 2bd9fd1 to d96ca0eCompare August 4, 2026 11:35

jgoux force-pushed the lazy-stack/06-detached-parity branch from 67ad946 to b9891e0Compare August 4, 2026 11:35

jgoux force-pushed the lazy-stack/05-port-leases branch from 86c6a70 to 9f2f7d4Compare August 4, 2026 12:03

jgoux force-pushed the lazy-stack/06-detached-parity branch from 6b836fd to e1d2245Compare August 4, 2026 12:03

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 9f2f7d4 to 868f236Compare August 4, 2026 12:12

jgoux force-pushed the lazy-stack/06-detached-parity branch from e1d2245 to f1319efCompare August 4, 2026 12:12

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StateManager.ts Outdated
Comment threadpackages/stack/src/RemoteStack.ts

jgoux force-pushed the lazy-stack/05-port-leases branch from 868f236 to 1ebb475Compare August 4, 2026 12:48

jgoux force-pushed the lazy-stack/06-detached-parity branch from f1319ef to e532be6Compare August 4, 2026 12:48

depthfirst-appBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/StateManager.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from 1ebb475 to cc5effcCompare August 4, 2026 12:58

jgoux force-pushed the lazy-stack/06-detached-parity branch from eb66904 to 938ee92Compare August 4, 2026 12:58

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/DaemonServer.ts Outdated

jgoux force-pushed the lazy-stack/05-port-leases branch from cc5effc to 9639149Compare August 4, 2026 13:20

jgoux force-pushed the lazy-stack/06-detached-parity branch from 938ee92 to 038fc01Compare August 4, 2026 13:20

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts Outdated
Comment threadpackages/stack/src/daemon.ts

jgoux added 7 commits August 4, 2026 15:59

fix(stack): preserve lazy lifecycle in detached mode
a93bb6f

fix(stack): stream lazy dormancy transitions
701fa89

fix(stack): serialize daemon state ownership
19375fa

fix(stack): reclaim daemon state locks
727138b

fix(stack): isolate state locks by user
49a4190

fix(stack): isolate daemon socket generations
a13e99e

fix(stack): harden detached shutdown ownership
d486dd6

jgoux force-pushed the lazy-stack/05-port-leases branch from 9639149 to 8d6ede9Compare August 4, 2026 14:06

jgoux force-pushed the lazy-stack/06-detached-parity branch from 038fc01 to d486dd6Compare August 4, 2026 14:06

chatgpt-codex-connectorBot reviewed Aug 4, 2026
View reviewed changes

Comment threadpackages/stack/src/ManagedPortLock.ts
Comment threadpackages/stack/src/RemoteStack.ts
Comment threadpackages/stack/src/layers.ts

jgoux mentioned this pull request Aug 5, 2026
feat(stack): add lazy service lifecycle #6070
Closed

jgoux closed this Aug 5, 2026

jgoux mentioned this pull request Aug 5, 2026
feat(stack): add hardened lazy service lifecycle #6072
Merged

Uh oh!

Conversation

jgoux commented Aug 3, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jgoux commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant