fix: consume vss-client 0.5.23 by ovitrif · Pull Request #1164 · synonymdev/bitkit-android

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:29Z

This PR bumps the VSS Android client from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Related: synonymdev/audit#55 (BITKIT-SEC-003).

Companion iOS PR: synonymdev/bitkit-ios#673

Preview

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local compileDevDebugKotlin, VssBackupClientTest, and detekt passed against 0.5.23.

greptile-apps · 2026-08-18T10:18:16Z

Greptile Summary

This PR makes VSS initialization fail closed when LNURL authentication is unavailable and upgrades the Android VSS client to the release that rejects unauthenticated encryption.

Removes unauthenticated backup-client and fixed-header Lightning-node fallbacks.
Adds a typed error for missing VSS authentication.
Updates vss-client-android from 0.5.21 to 0.5.23 and records the security change.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS enforced consistently across backup and Lightning persistence setup.

The changed setup paths reject blank LNURL-auth configuration before constructing a VSS client, while existing callers capture and propagate the resulting typed failure through their normal lifecycle handling.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt	Removes the unauthenticated backup fallback and requires a non-blank LNURL-auth endpoint before client initialization.
app/src/main/java/to/bitkit/data/backup/VssBackupClientLdk.kt	Applies the same fail-closed authentication requirement to LDK remote persistence.
app/src/main/java/to/bitkit/services/LightningService.kt	Prevents node construction through the fixed-header VSS fallback when LNURL authentication is unavailable.
app/src/main/java/to/bitkit/utils/Errors.kt	Adds the typed VssAuthRequired service precondition error.
gradle/libs.versions.toml	Upgrades the VSS Android client from 0.5.21 to 0.5.23.
changelog.d/next/consume-vss.security.md	Documents removal of unauthenticated VSS encryption fallback.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
Setup["Backup or Lightning setup"] --> Check{"LNURL-auth URL blank?"}
Check -- Yes --> Error["Throw VssAuthRequired"]
Check -- No --> Auth["Initialize authenticated VSS client"]
Auth --> VSS["Encrypted VSS persistence"]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif requested a review from ben-kaufman August 18, 2026 10:15

This was referenced Aug 18, 2026
fix: consume vss-client 0.5.23 synonymdev/bitkit-ios#673
Merged
fix: fail closed without vss auth #1156
Merged

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from 2b0823c to e069307Compare August 18, 2026 11:12

ovitrif changed the base branch from master to fix/fail-closed-unauthenticated-vssAugust 18, 2026 11:12

ovitrif self-assigned this Aug 18, 2026

ovitrif added this to the 2.5.0 milestone Aug 18, 2026

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from e069307 to 372dbfbCompare August 18, 2026 13:03

Base automatically changed from fix/fail-closed-unauthenticated-vss to masterAugust 18, 2026 13:47

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from 372dbfb to e649bc9Compare August 18, 2026 13:47

ben-kaufman approved these changes Aug 18, 2026
View reviewed changes

fix: consume vss-client 0.5.23
108c6c8
Bump vss-client-android to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from e649bc9 to 108c6c8Compare August 18, 2026 18:31

ovitrif merged commit 87f3b8f into masterAug 18, 2026
18 checks passed

ovitrif deleted the fix/consume-vss-0.5.23 branch August 18, 2026 19:50

piotr-iohk mentioned this pull request Aug 21, 2026
chore: bump version 2.4.1 #1174
Closed

piotr-iohk mentioned this pull request Aug 31, 2026
chore: sync 2.4.1 onto master #1197
Merged